Skip to content

fix(patch): cherry-pick 0659ad1 to release/v0.33.0-preview.0-pr-21042 to patch version v0.33.0-preview.0 and create version 0.33.0-preview.1#21047

Merged
jacob314 merged 1 commit into
release/v0.33.0-preview.0-pr-21042from
hotfix/v0.33.0-preview.0/0.33.0-preview.1/preview/cherry-pick-0659ad1/pr-21042
Mar 4, 2026
Merged

fix(patch): cherry-pick 0659ad1 to release/v0.33.0-preview.0-pr-21042 to patch version v0.33.0-preview.0 and create version 0.33.0-preview.1#21047
jacob314 merged 1 commit into
release/v0.33.0-preview.0-pr-21042from
hotfix/v0.33.0-preview.0/0.33.0-preview.1/preview/cherry-pick-0659ad1/pr-21042

Conversation

@gemini-cli-robot

Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit 0659ad1 to patch version v0.33.0-preview.0 in the preview release to create version 0.33.0-preview.1.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cherry-picks a critical fix from a previous commit to create a patch version v0.33.0-preview.1 for the CLI. The primary change involves elevating the priority of the global keypress handling mechanism, which resolves potential issues with key event processing. Concurrently, outdated tests related to UI expansion persistence have been removed to align with the updated keypress logic.

Highlights

  • Keypress Handling Priority: The global keypress handler in AppContainer.tsx has been updated to operate with a higher priority, changing from KeypressPriority.Low to true. This ensures that global keypress events are handled more consistently and reliably.
  • Test Suite Removal: The 'Expansion Persistence' test suite in AppContainer.test.tsx has been removed. These tests were likely no longer relevant or accurate following changes to how UI expansion and keypresses interact.
Changelog
  • packages/cli/src/ui/AppContainer.test.tsx
    • Removed the 'Expansion Persistence' test suite, including tests for keypress-driven UI expansion and collapse.
  • packages/cli/src/ui/AppContainer.tsx
    • Updated the useKeypress hook for handleGlobalKeypress to have a higher priority (priority: true) instead of KeypressPriority.Low.
Activity
  • This pull request was automatically generated by gemini-cli-robot to cherry-pick commit 0659ad1702f0efbba4c24da448f72c8ffece7868.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

Size Change: -22 B (0%)

Total Size: 25.9 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.4 MB -22 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a critical regression in the UI's expansion behavior by changing a keypress handler's priority. This causes the expanded view to collapse on any keypress, which is incorrect. Compounding this issue, the tests that would have caught this regression have been deleted. My feedback includes two critical comments: one to revert the problematic code change in AppContainer.tsx and another to restore the deleted tests in AppContainer.test.tsx.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/cli/src/ui/AppContainer.test.tsx (2547-2675)

critical

This entire test suite for "Expansion Persistence" has been deleted. These tests were crucial for verifying that the UI's expanded view behaves correctly, specifically:

  • It collapses when an unhandled key is pressed.
  • It remains expanded when a key is handled by a higher-priority component (e.g., navigation arrows).

The change in AppContainer.tsx (increasing handleGlobalKeypress priority) breaks this functionality, and these tests would have failed, correctly identifying the regression. Deleting tests to make a build pass is a dangerous practice that hides bugs and prevents future regressions.

These tests should be restored, and the issue in AppContainer.tsx should be fixed so that they pass.

packages/cli/src/ui/AppContainer.tsx (1876)

critical

Changing the keypress priority for handleGlobalKeypress from Low to High (since priority: true resolves to KeypressPriority.High) introduces a significant regression.

The logic within handleGlobalKeypress (lines 1713-1723) collapses the view (setConstrainHeight(true)) whenever it's expanded (!constrainHeight). With Low priority, this only happened for keypresses that were not handled by any other component (like the input prompt), which was the desired behavior for "collapse on any outside activity".

With High priority, this handler now runs before most others. As a result, any keypress (including typing characters into the input prompt) will cause the expanded view to collapse. This is a poor user experience and breaks the expansion persistence feature.

This change should be reverted to restore the correct behavior.

  useKeypress(handleGlobalKeypress, {
    isActive: true,
    priority: KeypressPriority.Low,
  });
References
  1. Maintain consistency with existing UI behavior across components. Defer non-standard UX pattern improvements to be addressed holistically rather than in a single component. This change introduces a regression in established UI behavior.

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 4, 2026

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacob314 jacob314 merged commit b21b289 into release/v0.33.0-preview.0-pr-21042 Mar 4, 2026
28 checks passed
@jacob314 jacob314 deleted the hotfix/v0.33.0-preview.0/0.33.0-preview.1/preview/cherry-pick-0659ad1/pr-21042 branch March 4, 2026 02:48
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m A medium sized PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants