-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add Codex CLI plugin manifest #24766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| { | ||||||
| "name": "gemini-cli", | ||||||
| "version": "0.1.0", | ||||||
| "description": "An open-source AI agent that brings the power of Gemini directly into your terminal.", | ||||||
| "author": { | ||||||
| "name": "google-gemini", | ||||||
| "url": "https://github.com/google-gemini" | ||||||
| }, | ||||||
| "homepage": "https://github.com/google-gemini/gemini-cli", | ||||||
| "repository": "https://github.com/google-gemini/gemini-cli", | ||||||
| "keywords": [ | ||||||
| "mcp", | ||||||
| "codex" | ||||||
| ], | ||||||
| "mcpServers": "./.mcp.json" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The relative path to the MCP configuration file is incorrect. Since plugin.json is located in the .codex-plugin/ subdirectory and .mcp.json is in the repository root, the path should be ../.mcp.json to correctly resolve the file.
Suggested change
|
||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Codex Plugin Quality Gate | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: codex-plugin-scanner-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| scan: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Codex plugin scanner | ||
| uses: hashgraph-online/hol-codex-plugin-scanner-action@e83708a91ae4812872aa2905b99ad559a55c74ab | ||
| with: | ||
| plugin_dir: "." | ||
| mode: scan | ||
| fail_on_severity: critical |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "mcpServers": { | ||
| "gemini-cli": { | ||
| "command": "node", | ||
| "args": [ | ||
| "bundle/gemini.js" | ||
| ] | ||
|
Comment on lines
+4
to
+7
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The command node bundle/gemini.js points to the main interactive CLI entry point. This entry point initializes a terminal UI (using the Ink/React framework) which outputs ANSI escape sequences and interactive prompts to stdout. This is incompatible with the Model Context Protocol (MCP), which requires stdout to be reserved exclusively for JSON-RPC messages. Using this entry point will cause protocol errors in MCP clients. Please point this to a dedicated non-interactive server entry point or ensure the CLI supports a flag (e.g., --mcp) that enables a pure MCP server mode. |
||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin name "gemini-cli" does not match the scoped package name defined in package.json ("@google/gemini-cli"). To avoid naming collisions in the Codex/MCP ecosystem and maintain consistency with the project's identity, it is recommended to use the full scoped name.