feat: support auth block in MCP servers config in agents#24770
feat: support auth block in MCP servers config in agents#24770TanmayVartak wants to merge 2 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces authentication capabilities for MCP servers defined in local agent markdown files. By adding an 'auth' block, users can now configure Google credentials or OAuth settings directly within their agent definitions, enabling secure access to MCP servers that require authentication. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for authentication configurations in MCP servers within agent definitions. It updates the mcpServerSchema to include google-credentials and oauth authentication types and modifies the markdownToAgentDefinition function to correctly map these configurations to MCPServerConfig. Additionally, a new test case was added to verify the conversion of MCP servers with Google credentials. I have no feedback to provide.
This PR adds support for the 'auth' block in the 'mcp_servers' section of agent markdown files, allowing local agents to configure Google credentials or OAuth for MCP servers.