Skip to content

fix(cli): always show shell command description or actual command#24774

Merged
jacob314 merged 3 commits intomainfrom
shell_command_summary
Apr 8, 2026
Merged

fix(cli): always show shell command description or actual command#24774
jacob314 merged 3 commits intomainfrom
shell_command_summary

Conversation

@jacob314
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 commented Apr 6, 2026

Summary

To repro:
Run this shell command and verify that with this fix you now see output.
Screenshot 2026-04-06 at 12 50 12 PM

Fixes #24775

@jacob314 jacob314 requested a review from a team as a code owner April 6, 2026 19:53
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the user experience of the CLI by ensuring that shell command descriptions are always informative. By defaulting to the raw command when a custom description is missing or invalid, it prevents empty or unhelpful labels from appearing in the interface.

Highlights

  • Improved Shell Command Descriptions: Updated the getDescription method to ensure that shell command invocations always provide a meaningful description, falling back to the actual command string if the provided description is empty or contains only whitespace.
  • Added Unit Tests: Included new test cases in shell.test.ts to verify that getDescription correctly handles valid descriptions, empty strings, and whitespace-only strings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Apr 6, 2026

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli Bot added the priority/p1 Important and should be addressed in the near term. label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

Size Change: +46 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-5SBZKKH2.js 0 B -3.15 MB (removed) 🏆
./bundle/chunk-7PQZJC44.js 0 B -14.8 MB (removed) 🏆
./bundle/core-SL3PPM2S.js 0 B -45.4 kB (removed) 🏆
./bundle/devtoolsService-T2IXWMAU.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-H6APCY53.js 0 B -1.64 MB (removed) 🏆
./bundle/oauth2-provider-QRX3WL26.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-3SNI624V.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-VM4LSXEM.js 3.15 MB +3.15 MB (new file) 🆕
./bundle/core-QQD6ADIH.js 45.4 kB +45.4 kB (new file) 🆕
./bundle/devtoolsService-C52YOC5C.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-Z5WD3CRS.js 1.64 MB +1.64 MB (new file) 🆕
./bundle/oauth2-provider-B2EDY5ZK.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/bundled/third_party/index.js 8 MB
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-5PS3AYFU.js 1.18 kB
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-Z34XA6FT.js 1.96 MB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-XB7DADIJ.js 418 B
./bundle/gemini.js 553 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-PYBLKP7S.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the getDescription method in the ShellToolInvocation class to return the raw command if the description is missing, empty, or contains only whitespace. Corresponding unit tests have been added to verify this behavior. I have no feedback to provide.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

61 tests passed successfully on gemini-3-flash-preview.

🧠 Model Steering Guidance

This PR modifies files that affect the model's behavior (prompts, tools, or instructions).

  • ⚠️ Consider adding Evals: No behavioral evaluations (evals/*.eval.ts) were added or updated in this PR. Consider adding a test case to verify the new behavior and prevent regressions.
  • 🚀 Maintainer Reminder: Please ensure that these changes do not regress results on benchmark evals before merging.

This is an automated guidance message triggered by steering logic signatures.

@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

🛑 Action Required: Evaluation Approval

Steering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged.

Maintainers:

  1. Go to the Workflow Run Summary.
  2. Click the yellow 'Review deployments' button.
  3. Select the 'eval-gate' environment and click 'Approve'.

Once approved, the evaluation results will be posted here automatically.

@jacob314 jacob314 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 28efab4 Apr 8, 2026
27 of 29 checks passed
@jacob314 jacob314 deleted the shell_command_summary branch April 8, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell commands sometimes lack a description

2 participants