Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of terminal alternate buffer detection within the CLI. By moving away from a hook-based utility and utilizing the configuration object directly, the application ensures that startup warnings are correctly contextualized based on the actual terminal buffer state. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors how the alternate buffer state is determined in the CLI's main entry point, replacing the isAlternateBufferEnabled utility with a direct call to config.getUseAlternateBuffer(). It also adds a comprehensive test case to verify that startup warnings correctly receive the alternate buffer state. A review comment correctly points out a violation of the project's testing conventions regarding the manual manipulation of process.env, suggesting the use of vi.stubEnv instead.
|
Size Change: -128 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
gemini-cli
bot
added
the
area/core
| .mockImplementation(() => {}); | ||
|
|
||
| process.env['GEMINI_API_KEY'] = 'test-key'; | ||
| vi.stubEnv('GEMINI_API_KEY', 'test-key'); |
There was a problem hiding this comment.
fix bug where we were stubbing env vars the wrong way across these tests.
1 participant
Summary
Users got a warning about tmux not being compatible with alternate buffer mode even when not in alternate buffer mode.
Details
We were checking the wrong option to show the tmux warning. We needed the true alternateBuffer flag rather than the flag also set to true for terminalBuffer while we are migrating.
Related Issues
Fixes #24790