refactor(cli): remove duplication in interactive shell awaiting input hint#24801
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the interactive shell waiting hint by centralizing the message string into a shared constant. This change eliminates code duplication across the UI components and updates the message text to improve the user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the 'Shell awaiting input' status message by replacing the hardcoded string in StatusRow.tsx with the INTERACTIVE_SHELL_WAITING_PHRASE constant. Additionally, the phrase itself was updated to include a question mark, and the corresponding test expectation was updated to match. I have no feedback to provide.
|
Note that we normally do not have time to review external PRs for issues that are not marked |
Refactors StatusRow.tsx to use the INTERACTIVE_SHELL_WAITING_PHRASE constant from usePhraseCycler.ts instead of a hardcoded string, removing duplication and improving maintainability. Reverted the experimental question mark addition as requested.
Fixes #24800