Skip to content

refactor(cli): remove duplication in interactive shell awaiting input hint#24801

Merged
scidomino merged 3 commits intogoogle-gemini:mainfrom
JayadityaGit:fix/ui-hint-awaiting-input
Apr 8, 2026
Merged

refactor(cli): remove duplication in interactive shell awaiting input hint#24801
scidomino merged 3 commits intogoogle-gemini:mainfrom
JayadityaGit:fix/ui-hint-awaiting-input

Conversation

@JayadityaGit
Copy link
Copy Markdown
Contributor

@JayadityaGit JayadityaGit commented Apr 7, 2026

Refactors StatusRow.tsx to use the INTERACTIVE_SHELL_WAITING_PHRASE constant from usePhraseCycler.ts instead of a hardcoded string, removing duplication and improving maintainability. Reverted the experimental question mark addition as requested.

Fixes #24800

@JayadityaGit JayadityaGit requested a review from a team as a code owner April 7, 2026 01:25
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the interactive shell waiting hint by centralizing the message string into a shared constant. This change eliminates code duplication across the UI components and updates the message text to improve the user experience.

Highlights

  • Code Duplication: Replaced a hardcoded string in the StatusRow component with a centralized constant to improve maintainability.
  • UX Improvement: Updated the interactive shell waiting message to include a question mark for better clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the 'Shell awaiting input' status message by replacing the hardcoded string in StatusRow.tsx with the INTERACTIVE_SHELL_WAITING_PHRASE constant. Additionally, the phrase itself was updated to include a question mark, and the corresponding test expectation was updated to match. I have no feedback to provide.

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 7, 2026
@JayadityaGit JayadityaGit changed the title refactor(cli): update interactive shell awaiting input hint and remove duplication refactor(cli): remove duplication in interactive shell awaiting input hint Apr 7, 2026
@JayadityaGit JayadityaGit requested a review from scidomino April 7, 2026 22:54
@scidomino
Copy link
Copy Markdown
Collaborator

Note that we normally do not have time to review external PRs for issues that are not marked help-wanted. I'm making an exception here because it was a one liner and I happened to see it.

@scidomino scidomino enabled auto-merge April 7, 2026 23:28
@scidomino scidomino added this pull request to the merge queue Apr 7, 2026
Merged via the queue into google-gemini:main with commit 1aa798d Apr 8, 2026
29 checks passed
@JayadityaGit JayadityaGit deleted the fix/ui-hint-awaiting-input branch April 8, 2026 00:25
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor interactive shell awaiting input hint to remove duplication

2 participants