feat(cli): enable permanent tool approval by default#25823
Conversation
gemini-cli
Bot
added
the
🔒 maintainer only
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request changes the default behavior of the CLI tool approval process to improve user experience by enabling permanent tool approval by default. This adjustment ensures that users are presented with the option to allow tools for future sessions without needing to manually change their settings, streamlining workflows that involve repeated tool usage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default value of security.enablePermanentToolApproval from false to true, modifying documentation, the settings schema, and associated test snapshots. The UI now includes the permanent approval option by default in tool confirmation dialogs. Feedback points to a potential bug in the ToolConfirmationQueue component, where the hidden line count is not consistently updated when content is pushed out of the visible area in the snapshots.
Note: Security Review did not run due to the size of the PR.
|
Size Change: -5 B (0%) Total Size: 33.7 MB
ℹ️ View Unchanged
|
Adib234
force-pushed
the
adibakm/permanent-tool-approval
branch
2 times, most recently
from
42c828c to
c620e25
Compare
Adib234
force-pushed
the
adibakm/permanent-tool-approval
branch
from
c620e25 to
dcc69bd
Compare
2 participants
Summary
Enable
enablePermanentToolApprovalby default to show the "Allow for all future sessions" option in tool confirmation dialogs by default.Details
packages/cli/src/config/settingsSchema.tsto set the default value ofenablePermanentToolApprovaltotrue.packages/cli/src/ui/components/messages/ToolConfirmationMessage.test.tsxto reflect the new default behavior.packages/clias the "Allow for all future sessions" option is now visible by default in many scenarios.Related Issues
Closes #25820
How to Validate
npm run buildthennpm run start(or any tool that requires confirmation).npm test -w packages/cliand verify all tests pass.Pre-Merge Checklist