Skip to content

feat(cli): enable permanent tool approval by default#25938

Closed
Adib234 wants to merge 3 commits into
mainfrom
adibakm/permanent-tool-approval-2
Closed

feat(cli): enable permanent tool approval by default#25938
Adib234 wants to merge 3 commits into
mainfrom
adibakm/permanent-tool-approval-2

Conversation

@Adib234

@Adib234 Adib234 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Enables the security.enablePermanentToolApproval setting by default. This change makes the "Allow for all future sessions" option available in tool confirmation dialogs without requiring manual configuration.

Details

This PR updates the default value of enablePermanentToolApproval from false to true in packages/cli/src/config/settingsSchema.ts. It also updates the corresponding documentation in docs/cli/settings.md and docs/reference/configuration.md to reflect the new default state.

Related Issues

Fixes #25820

How to Validate

  1. Run the CLI with default settings.
  2. Trigger a tool that requires confirmation (e.g., a shell command).
  3. Verify that the "Allow for all future sessions" option is visible in the confirmation prompt.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Adib234 Adib234 requested review from a team as code owners April 24, 2026 19:17
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default behavior of the CLI to enable permanent tool approval. By changing this setting to true by default, users will now see the 'Allow for all future sessions' option in tool confirmation dialogs without needing to manually modify their configuration, streamlining the user experience for recurring tool interactions.

Highlights

  • Default Configuration Change: Updated the default value of 'security.enablePermanentToolApproval' from false to true in the CLI settings schema.
  • Documentation Updates: Reflected the new default setting in both the CLI settings documentation and the configuration reference guide.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default value of the security.enablePermanentToolApproval setting from false to true across the documentation and the CLI configuration schema. This change enables the "Allow for all future sessions" option in tool confirmation dialogs by default. I have no feedback to provide.

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown

Size Change: -5 B (0%)

Total Size: 33.7 MB

Filename Size Change
./bundle/chunk-5KKZE4NG.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-CCSBTLO5.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-EKACZSMX.js 0 B -669 kB (removed) 🏆
./bundle/chunk-KSHEKKW7.js 0 B -14.6 MB (removed) 🏆
./bundle/chunk-RUMNK5DB.js 0 B -2.73 MB (removed) 🏆
./bundle/chunk-ZT7HP3LQ.js 0 B -49.2 kB (removed) 🏆
./bundle/core-TD3ZAZZY.js 0 B -47.7 kB (removed) 🏆
./bundle/devtoolsService-WLVIGRDN.js 0 B -27.8 kB (removed) 🏆
./bundle/gemini-PNCVIZ5S.js 0 B -578 kB (removed) 🏆
./bundle/interactiveCli-Y57RG4Y4.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-XXPPDGSO.js 0 B -2.08 kB (removed) 🏆
./bundle/oauth2-provider-XPBKWHDF.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-MEHWF4OO.js 669 kB +669 kB (new file) 🆕
./bundle/chunk-NKGRR5WN.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-ON7VWO64.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-RKYA2NVR.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-V3OQBCY7.js 14.6 MB +14.6 MB (new file) 🆕
./bundle/chunk-WM4TV7SX.js 2.73 MB +2.73 MB (new file) 🆕
./bundle/core-6FK4K4EV.js 47.7 kB +47.7 kB (new file) 🆕
./bundle/devtoolsService-RXVRQ5DE.js 27.8 kB +27.8 kB (new file) 🆕
./bundle/gemini-OVMSPBWU.js 578 kB +578 kB (new file) 🆕
./bundle/interactiveCli-AC33KBUB.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-PM5LS5LP.js 2.08 kB +2.08 kB (new file) 🆕
./bundle/oauth2-provider-V6VUQUHK.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-MTD736U4.js 1.97 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-WJO4E4E3.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 4.97 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-NSOLCG4U.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-6NCMHHVA.js 0 B -622 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-HSIPWDXZ.js 932 B +932 B (new file) 🆕
./bundle/start-6TMY4PTM.js 622 B +622 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added the 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. label Apr 24, 2026
@Adib234 Adib234 closed this May 5, 2026
@sripasg sripasg added the size/xl An extra large PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. size/xl An extra large PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable permanent tool approval by default

2 participants