Skip to content

fix(cli): enable adk non-interactive session#26895

Merged
adamfweidman merged 2 commits into
mainfrom
fix/adk-noninteractive-and-comment
May 11, 2026
Merged

fix(cli): enable adk non-interactive session#26895
adamfweidman merged 2 commits into
mainfrom
fix/adk-noninteractive-and-comment

Conversation

@adamfweidman

@adamfweidman adamfweidman commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR enables the ADK agent session for non-interactive mode by default in settings and logs its usage.

Details

  • Added adk.agentSessionNoninteractiveEnabled: true to .gemini/settings.json.
  • Added a debug log in nonInteractiveCli.ts when using the ADK agent session.

Related Issues

None.

How to Validate

  1. Run the CLI in non-interactive mode.
  2. Check the debug logs to see [ADK] Running non-interactive mode with ADK agent session.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@adamfweidman adamfweidman requested review from a team as code owners May 11, 2026 21:53
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown

⚠️ Invocation Drift Warning

The following file pairs should generally be kept in sync during the AgentSession migration:

  • non-interactive CLI: packages/cli/src/nonInteractiveCli.ts was modified but packages/cli/src/nonInteractiveCliAgentSession.ts was not.

If this is intentional (e.g., a bug fix specific to one implementation), you can ignore this comment.

This check will be removed once the legacy implementations are deleted.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables the ADK agent session for non-interactive CLI operations and improves system observability through new debug logs. Additionally, it introduces extensive documentation to support the ongoing architectural migration to the ADK framework, providing clarity on system alignment and design priorities.

Highlights

  • ADK Integration: Enabled the ADK agent session for non-interactive CLI mode by default.
  • Observability: Added debug logging to track usage of the ADK agent session in non-interactive mode.
  • Documentation: Added a comprehensive suite of documentation covering ADK alignment, architecture, cross-SDK comparisons, and migration design.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/settings.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a comprehensive architectural design and alignment documentation for migrating the Gemini CLI backend to the Agent Development Kit (ADK). The documentation includes detailed field-by-field mappings, architecture notes for both ADK and the existing CLI, a cross-SDK comparison to validate the proposed event taxonomy, and a high-level migration design document. Additionally, a minor code change was implemented in packages/cli/src/nonInteractiveCli.ts to include a debug log when running in non-interactive mode with an ADK agent session. There are no review comments to address, and I have no further feedback to provide.

@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown

Size Change: +92 B (0%)

Total Size: 34.1 MB

Filename Size Change
./bundle/chunk-5WZP6RI4.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-CUXGOAWP.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-JYHWCNJL.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-O3KHMJIX.js 0 B -658 kB (removed) 🏆
./bundle/chunk-QGT3E5C2.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-RXHCJWUV.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-SQHH3FCH.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-U63K3CAM.js 0 B -19.5 kB (removed) 🏆
./bundle/core-6P5XMOYO.js 0 B -49.2 kB (removed) 🏆
./bundle/devtoolsService-U7RMK4GD.js 0 B -28 kB (removed) 🏆
./bundle/gemini-I2I6GK3V.js 0 B -587 kB (removed) 🏆
./bundle/interactiveCli-HPK66MEX.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-3D762B3H.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-WUU3NNWO.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-25DH3RGN.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-2MVXABPN.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-32QPYMPR.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-KBALKH5D.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-OCHJZSWY.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-USI6ZJ7I.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-WLG2ZGE7.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/chunk-Z5DNZSVD.js 658 kB +658 kB (new file) 🆕
./bundle/core-K7A52UQK.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/devtoolsService-ZARKRUFR.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-X25JCBKR.js 587 kB +587 kB (new file) 🆕
./bundle/interactiveCli-IFW756XR.js 1.3 MB +1.3 MB (new file) 🆕
./bundle/liteRtServerManager-IIS2H27C.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-OVQX2C47.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-QTB23IKC.js 1.97 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-3E2TPC63.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-PTF4YLMR.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-6HCEIOYI.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-7ANUYCIZ.js 932 B +932 B (new file) 🆕
./bundle/start-WCVMLX62.js 652 B +652 B (new file) 🆕

compressed-size-action

@adamfweidman adamfweidman force-pushed the fix/adk-noninteractive-and-comment branch from 1c02748 to 682057a Compare May 11, 2026 21:57
@adamfweidman adamfweidman changed the title fix(cli): enable adk non-interactive session and remove comment fix(cli): enable adk non-interactive session May 11, 2026
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label May 11, 2026
@adamfweidman adamfweidman enabled auto-merge May 11, 2026 23:25
@adamfweidman adamfweidman added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit 24b98ad May 11, 2026
28 checks passed
@adamfweidman adamfweidman deleted the fix/adk-noninteractive-and-comment branch May 11, 2026 23:51
@sripasg sripasg added the size/xs An extra small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs An extra small PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants