fix(patch): cherry-pick bd53951 to release/v0.44.0-pr-27496 [CONFLICTS]#27534
Conversation
# Conflicts: # packages/cli/index.ts # packages/core/src/services/shellExecutionService.ts
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to backport a fix for PTY resize-related native crashes to the v0.44.x release branch. The changes introduce more robust error checking and process validation when resizing terminal sessions to handle race conditions more gracefully. Please note that this PR currently contains unresolved merge conflicts that must be addressed before it can be merged. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to harden PTY resizing against native crashes by catching and ignoring specific errors (such as EBADF, ESRCH, and Windows-specific exit errors) during resize operations in packages/cli and packages/core. However, the changes currently contain unresolved Git merge conflict markers in both modified files. There are no review comments to evaluate, so no feedback on comments is provided.
|
Size Change: +551 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
gemini-cli
Bot
added
the
status/need-issue
scidomino
deleted the
hotfix/v0.44.0/0.44.1/stable/cherry-pick-bd53951/pr-27496
branch
2 participants
This PR automatically cherry-picks commit bd53951 to patch version v0.44.0 in the stable release to create version 0.44.1.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: