Skip to content

fix(patch): cherry-pick f40498d to release/v0.46.0-preview.1-pr-27676 to patch version v0.46.0-preview.1 and create version 0.46.0-preview.2 #27699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galdawave merged 1 commit into from
Jun 5, 2026
+19 −3
Merged

fix(patch): cherry-pick f40498d to release/v0.46.0-preview.1-pr-27676 to patch version v0.46.0-preview.1 and create version 0.46.0-preview.2 #27699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/cli/src/ui/hooks/useBanner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,24 @@ describe('useBanner', () => {
.update(defaultBannerData.defaultText)
.digest('hex')]: 5,
});
});

it('should not hide banner if show count exceeds max limit (Legacy format) if it contains an Antigravity announcement', async () => {
const antigravityBannerData = {
defaultText: 'Antigravity is coming to town!',
warningText: '',
};

mockedPersistentStateGet.mockReturnValue({
[crypto
.createHash('sha256')
.update(antigravityBannerData.defaultText)
.digest('hex')]: 5,
});

const { result } = await renderHook(() => useBanner(defaultBannerData));
const { result } = await renderHook(() => useBanner(antigravityBannerData));

expect(result.current.bannerText).toBe('');
expect(result.current.bannerText).toBe('Antigravity is coming to town!');
});
Comment on lines +80 to 98

@gemini-code-assist gemini-code-assist Bot Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The cherry-pick or patch modification accidentally truncated the existing test 'should hide banner if show count exceeds max limit (Legacy format)'. This restores the original test's assertion. Additionally, ensure that all banners, including those with warnings or special announcements like Antigravity, are hidden after reaching the maximum display count.

    const { result } = await renderHook(() => useBanner(defaultBannerData));

    expect(result.current.bannerText).toBe('');
  });

  it('should hide banner if show count exceeds max limit (Legacy format) even if it contains an Antigravity announcement', async () => {
    const antigravityBannerData = {
      defaultText: 'Antigravity is coming to town!',
      warningText: '',
    };

    mockedPersistentStateGet.mockReturnValue({
      [crypto
        .createHash('sha256')
        .update(antigravityBannerData.defaultText)
        .digest('hex')]: 5,
    });

    const { result } = await renderHook(() => useBanner(antigravityBannerData));

    expect(result.current.bannerText).toBe('');
  });
References
  1. Banners, including those with warnings, should be hidden after reaching a maximum display count.


it('should increment the persistent count when banner is shown', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cli/src/ui/hooks/useBanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export function useBanner(bannerData: BannerData) {
const currentBannerCount = bannerCounts[hashedText] || 0;

const showBanner =
activeText !== '' && currentBannerCount < DEFAULT_MAX_BANNER_SHOWN_COUNT;
activeText !== '' &&
(currentBannerCount < DEFAULT_MAX_BANNER_SHOWN_COUNT ||
activeText.includes('Antigravity'));

const rawBannerText = showBanner ? activeText : '';
const bannerText = rawBannerText.replace(/\\n/g, '\n');
Expand Down
Loading