Skip to content

fix(a2a-server): add missing return after 501 response in GET /tasks/metadata#27754

Open
aniruddhaadak80 wants to merge 1 commit into
google-gemini:mainfrom
aniruddhaadak80:fix-issue-21729
Open

fix(a2a-server): add missing return after 501 response in GET /tasks/metadata#27754
aniruddhaadak80 wants to merge 1 commit into
google-gemini:mainfrom
aniruddhaadak80:fix-issue-21729

Conversation

@aniruddhaadak80

Copy link
Copy Markdown
Contributor

Fixes #21729

Added the missing
eturn;\ statement after sending a 501 response in \packages/a2a-server/src/http/app.ts\ to prevent it from falling through to the rest of the endpoint handling, which resulted in \ERR_HTTP_HEADERS_SENT\ and crashed the A2A server.

@aniruddhaadak80 aniruddhaadak80 requested a review from a team as a code owner June 9, 2026 14:16
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a server crash issue where the application continued to execute code after sending a 501 error response. By adding the missing return, the request lifecycle is correctly terminated, preventing the ERR_HTTP_HEADERS_SENT error.

Highlights

  • Bug Fix: Added a missing return statement after sending a 501 error response in the GET /tasks/metadata endpoint to prevent execution fall-through.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/xs An extra small PR label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📊 PR Size: size/XS

  • Lines changed: 1
  • Additions: +1
  • Deletions: -0
  • Files changed: 1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a missing return; statement in packages/a2a-server/src/http/app.ts within the error handling block for unsupported task stores. This ensures that execution stops after sending the error response, preventing subsequent code from running. There are no review comments, and I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p1 Important and should be addressed in the near term. area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p1 Important and should be addressed in the near term. size/xs An extra small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: A2A server GET /tasks/metadata missing return after 501 response — causes ERR_HTTP_HEADERS_SENT crash with GCS task store

1 participant