fix(a2a-server): add missing return after 501 response in GET /tasks/metadata#27754
fix(a2a-server): add missing return after 501 response in GET /tasks/metadata#27754aniruddhaadak80 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a server crash issue where the application continued to execute code after sending a 501 error response. By adding the missing return, the request lifecycle is correctly terminated, preventing the ERR_HTTP_HEADERS_SENT error. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XS
|
There was a problem hiding this comment.
Code Review
This pull request adds a missing return; statement in packages/a2a-server/src/http/app.ts within the error handling block for unsupported task stores. This ensures that execution stops after sending the error response, preventing subsequent code from running. There are no review comments, and I have no feedback to provide.
Fixes #21729
Added the missing
eturn;\ statement after sending a 501 response in \packages/a2a-server/src/http/app.ts\ to prevent it from falling through to the rest of the endpoint handling, which resulted in \ERR_HTTP_HEADERS_SENT\ and crashed the A2A server.