fix: resolve workspace publish failures and scheduler event loop starvation#28063
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the stability of the nightly release pipeline by ensuring that npm publish commands do not attempt to execute lifecycle scripts. By bypassing these redundant steps, the CI process avoids incorrect environment resolution issues that were causing build failures during package publication. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release publishing GitHub action by adding the --ignore-scripts flag to the npm publish commands for the core, CLI, and A2A packages. This prevents lifecycle scripts from running during the publishing process. There are no review comments, and I have no feedback to provide.
gemini-cli
Bot
added
the
status/need-issue
Replace queueMicrotask with setTimeout(..., 10) inside _processNextItem loop to allow the event loop's macrotask queue (I/O, timers, child processes) to execute when waiting for external events. Also update parallel tools integration test and mocks.
…ting in CI Add a non-strict option to TestRig.setup to launch the CLI with --fake-responses-non-strict. This allows the integration tests to match mock responses by method name and ignore order differences caused by model-routing (classifier) being active or inactive in different environments (local vs CI).
rmedranollamas
changed the title
16 commits ahead of main-api-integration at sync time: - f8541cf fix/verify release npm ci ignore scripts (google-gemini#28116) - 6e0bd68 Add JSON output for eval inventory (google-gemini#28058) - d3ef6ac fix(ci): use wombat dressing room fallback in nightly release to prevent ENEEDAUTH (google-gemini#28104) - be7ba2c fix: resolve workspace publish failures and scheduler event loop starvation (google-gemini#28063) - c22137e feat: add eval:inventory CLI command and reporting logic (google-gemini#28009) - 6613e12 fix(ci): append trailing slash to registry url in npmrc (google-gemini#28038) - 93844df chore(deps): pin dependencies and enforce 14-day update cooldown (google-gemini#27948) - c427d18 fix(ci): provide fallbacks for package variables in nightly release (google-gemini#28016) - d5e25b9 Changelog for v0.48.0-preview.0 (google-gemini#27999) - 7ef3b4e chore(release): bump version to 0.49.0-nightly.20260617.g4d3dcdce1 (google-gemini#28003) - 4d3dcdc Revert "fix(core-tools): resolve defensive path resolution for at-reference files" (google-gemini#27992) - f741d03 fix(core-tools): resolve defensive path resolution for at-reference files (google-gemini#27943) - 926f3d9 fix(config): migrate coreTools setting to tools.core (google-gemini#27947) - 97455e5 Add static eval source analyzer (google-gemini#27631) - 5624a3b fix(cli): handle tmux false positive background detection (google-gemini#27572) - fbce3e5 feat(core): Support GDC air-gapped Service Identity after auth library update (google-gemini#27956) Conflict resolution: - packages/core/package.json: upstream pinned all dep versions (no caret) per 93844df (chore(deps): pin dependencies and enforce 14-day update cooldown). Kept fork-specific 'openai: 4.104.0' (pinned to match new policy) for MiniMax OpenAI-compat API integration. - packages/vscode-ide-companion/package.json: took upstream's pinned versions (no fork-specific deps). - package-lock.json: regenerated via 'npm install' after taking upstream's lockfile via 'git checkout --theirs'. Verification: - npm run build: pass - npm run typecheck: pass (0 errors) - npm test --workspace=@google/gemini-cli -- --run: 463 files / 6914 pass, 4 skipped, 0 fail - npm test --workspace=@google/gemini-cli-core -- --run: 403 files, 7710 tests run (12 fail originally, 2 fixed via UPDATE_GOLDENS=true golden regen on src/services/modelConfig.golden.test.ts). REMAINING 10 FAILURES in memory/AGENTS.md/scoped workspace path validation tests are KNOWN UPSTREAM BEHAVIOR DRIFT — upstream commit pair (f741d03 + 4d3dcdc revert) left tests in intermediate state (expect deny, code allows). Tracked for separate fix; not blocking the merge per user direction. Snapshot regen: - packages/core/src/services/test-data/resolved-aliases.golden.json - packages/core/src/services/test-data/resolved-aliases-retry.golden.json (regenerated via UPDATE_GOLDENS=true, see pitfall google-gemini#4 in autonomous-ai-agents/gemini-cli skill)
…vation (google-gemini#28063) (cherry picked from commit be7ba2c)
2 participants
Summary
This PR resolves two major issues:
--ignore-scriptsflag tonpm publishcommands inside.github/actions/publish-releaseto prevent running redundant package lifecycle scripts (like the rootpreparescript) during workspace publishing in CI.queueMicrotaskyield withsetTimeout(resolve, 10)inScheduler._processNextItem.Details
1. NPM Publish Lifecycle Failures
During nightly releases, when NPM publishes
@google/gemini-cli-corefrom its workspace, it automatically triggers thepreparescript. Because the workspace lacks a separatepreparescript, NPM invokes the root package'spreparescript (husky && npm run bundlewhich runsesbuild.config.js). Since the context has shifted to thecorepackage, the dependencies of@google/gemini-cli(e.g.,dotenv,comment-json,clipboardy) are completely unresolved, causing compilation to fail with 19 errors. Since all packages are already fully built and bundled in preceding CI steps, running these lifecycle scripts on publish is redundant and error-prone. Passing--ignore-scriptssafely prevents them from running and secures a clean release publish.2. Scheduler Event Loop Starvation
running Gemini CLI with parallel tool execution (such as multiple reads/writes in waves) on macOS would completely hang the CLI process. This was caused by the
_processNextItemexecution loop insidepackages/core/src/scheduler/scheduler.tsusingqueueMicrotaskto busy-wait while waiting for active tools or user confirmations. Since microtasks run with priority in the same tick of the event loop, this busy-wait loop completely starved the event loop's macrotask queue (I/O, timers, child processes), preventing the tools from ever dispatching their completion callbacks and deadlocking the CLI at 100% CPU. Replacing this withsetTimeout(resolve, 10)safely yields to the macrotask phase of the event loop, freeing the CPU and allowing React/Ink's render pipeline, standard I/O, and child processes to execute. We also added support for non-strict mock matching (fakeResponsesNonStrict) inTestRigto ensure the integration tests match mock responses correctly whether the model-routing classifier is active (locally) or bypassed (in CI).Related Issues
How to Validate
packages/core/src/scheduler/(149 tests) and integration tests (parallel-tools.test.ts) pass flawlessly.npm run lintandnpm run typecheckrun successfully.Pre-Merge Checklist