Feat/tool registry discovery#28113
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a structured tool registry to manage built-in tools and their categories, while simultaneously enhancing the eval analysis framework to track tool usage. By statically extracting tool references from eval assertions, the system can now better validate tool names and improve reporting accuracy during evaluation runs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/L
|
There was a problem hiding this comment.
Code Review
This pull request introduces a tool registry utility (tool-registry.ts) and updates the eval analysis script (eval-analysis.ts) to statically extract and resolve tool references from eval assertions, accompanied by comprehensive unit tests. The feedback correctly identifies that validating tool names solely against the built-in tool registry will cause false-positive warnings for valid Model Context Protocol (MCP) or dynamically discovered tools. To resolve this, the reviewer suggests importing and utilizing isValidToolName from @google/gemini-cli-core to properly handle non-built-in tool name patterns.
c3cafad to
4ce0836
Compare
(cherry picked from commit d845bc5)
Summary
Adds a small tool registry for eval reporting, plus AST extraction for the tool names used inside eval assertions.
Details
ALL_BUILTIN_TOOL_NAMESandTOOL_LEGACY_ALIASESin@google/gemini-cli-core.Pre-Merge Checklist