Skip to content

fix(core): buffer chat compression telemetry#28162

Open
mturac wants to merge 1 commit into
google-gemini:mainfrom
mturac:izon/fix-chat-compression-telemetry
Open

fix(core): buffer chat compression telemetry#28162
mturac wants to merge 1 commit into
google-gemini:mainfrom
mturac:izon/fix-chat-compression-telemetry

Conversation

@mturac

@mturac mturac commented Jun 26, 2026

Copy link
Copy Markdown

Summary

  • wrap chat compression OTEL log emission and metrics in the telemetry buffer
  • update the logChatCompression regression test to prove the buffered callback owns both operations

Fixes #23445

Validation

  • npm run test --workspace @google/gemini-cli-core -- src/telemetry/loggers.test.ts -t logChatCompression
  • npm run typecheck --workspace @google/gemini-cli-core

@mturac mturac requested a review from a team as a code owner June 26, 2026 17:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the telemetry handling for chat compression events by moving log emission and metric recording into the telemetry buffer. This change ensures that these operations are managed consistently with other buffered telemetry events, improving reliability and performance. The associated regression test has been updated to confirm that the buffered callback correctly triggers both the log emission and the metrics recording.

Highlights

  • Telemetry Buffering: Wrapped chat compression OpenTelemetry log emission and metrics recording within the telemetry buffer to ensure consistent event handling.
  • Regression Testing: Updated the logChatCompression test suite to verify that the buffered callback correctly executes both logging and metric recording operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/m A medium sized PR label Jun 26, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/M

  • Lines changed: 50
  • Additions: +32
  • Deletions: -18
  • Files changed: 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request wraps the OpenTelemetry logging and metrics recording for chat compression events inside a bufferTelemetryEvent callback within logChatCompression. It also updates the corresponding unit tests in loggers.test.ts to mock and verify this buffering behavior. I have no feedback to provide as there are no review comments and the changes are correct.

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/enterprise Issues related to Telemetry, Policy, Quota / Licensing labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/enterprise Issues related to Telemetry, Policy, Quota / Licensing priority/p2 Important but can be addressed in a future release. size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug(telemetry): logChatCompression bypasses bufferTelemetryEvent wrapper

1 participant