fix(core): prevent AbortSignal listener leak in ShellExecutionService

[Arjan-P]

Summary

• fix(core): prevent AbortSignal listener leak in ShellExecutionService

Details

Ensured the AbortSignal event listener is explicitly removed when a process finishes naturally, preventing potential memory leaks during long-lived CLI sessions.

Related Issues

Fixes #28280

Validate

Run npm test -w @google/gemini-cli-core -- src/service/shellExecutionService.test.ts
Should pass all 66 tests

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a memory leak issue within the ShellExecutionService by ensuring that event listeners attached to the AbortSignal are properly cleaned up once the execution process finishes. This improvement is particularly important for long-running CLI sessions where accumulated listeners could lead to performance degradation.

Highlights

• Memory Leak Prevention: Explicitly removes the AbortSignal event listener after the process completes to prevent potential memory leaks.
• Refactored Abort Handling: Introduced a named reference for the abort handler to allow for proper cleanup via removeEventListener.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

📊 PR Size: size/XS

• Lines changed: 7
• Additions: +6
• Deletions: -1
• Files changed: 1

[gemini-code-assist]

Code Review

This pull request updates ShellExecutionService to properly clean up the abort event listener on the abortSignal once the execution promise race (between processing completion and abort firing) is resolved, preventing potential memory leaks. There are no review comments, and I have no additional feedback to provide.