Tidy implementation detail in gemini-cli (#28340)#28366
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
📊 PR Size: size/XL
|
🛑 Action Required: Evaluation ApprovalSteering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged. Maintainers:
Once approved, the evaluation results will be posted here automatically. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on minor code hygiene improvements. It primarily addresses trailing whitespace in various test and evaluation files and removes several outdated SVG snapshot files, contributing to a cleaner and more maintainable codebase without introducing new features or significant behavioral changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request performs minor whitespace cleanup by removing trailing spaces in several evaluation and integration test files, including evals/automated-tool-use.eval.ts, evals/prompt_injection_mcp.eval.ts, evals/update_topic.eval.ts, and integration-tests/hooks-system.test.ts. Additionally, a series of unused SVG files representing terminal UI recordings or mockups have been deleted. There are no review comments associated with this pull request, and I have no feedback to provide.
Note: Security Review did not run due to the size of the PR.
Small scoped patch based on the reported behavior.
Related to #28340.