feat(CI): Package docker containers to GHCR for PRs.#8588
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @richieforeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily enhances the continuous integration pipeline by introducing an automated mechanism to build and publish Docker images to GitHub Container Registry for each pull request. This ensures that containerized versions of the application are readily available for testing and deployment. Concurrently, it refines the system prompt generation logic within the core client, making it more robust and configurable, and introduces a new instruction registry for better management of system instructions.
Highlights
- New GitHub Action for Docker Packaging: A new reusable GitHub Action (
push-docker/action.yml) has been added to build and push Docker images to GitHub Container Registry (GHCR) based on a given Git SHA. This action handles checkout, dependency installation, Docker build, package packing, GHCR login, image tagging based on branch name, and pushing the image. It also includes failure handling to create a GitHub issue if the build fails. - CI Integration Preparation: This new action is intended to be integrated into the main CI workflow (
CI.yaml) to automatically package Docker containers for pull requests, streamlining the process of creating and testing containerized versions of the application. - Asynchronous System Prompt Generation: The
getCoreSystemPromptfunction inpackages/core/src/core/prompts.tshas been refactored to be asynchronous and now accepts aConfigobject, allowing for more dynamic and configurable system prompt generation based on application settings and potentially external factors. - System Prompt Call Update: The
GeminiClientinpackages/core/src/core/client.tshas been updated toawaitthe call to the now-asynchronousgetCoreSystemPromptand pass the necessary configuration object, ensuring proper handling of the updated function signature. - Instruction Registry Introduction: A new
InstructionRegistryclass has been introduced inpackages/core/src/prompts/instruction-registry.ts. This class provides a mechanism to manage and register unique instructions using a Set data structure. - Test Server Configuration Update: The
TestMcpServerinintegration-tests/test-mcp-server.tshas been modified to include aninstructionsfield within its capabilities, setting it to 'I am a test server'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub action for building and pushing Docker containers to GHCR for pull requests. My review has identified a critical security vulnerability in this new action that could allow for secret exfiltration. It's crucial to address this before merging. Additionally, I've noted some dead code related to an incomplete feature that should be cleaned up to improve code maintainability.
mattKorwel
reviewed
Sep 17, 2025
mattKorwel
approved these changes
Sep 17, 2025
mattKorwel
left a comment
mattKorwel
left a comment
Collaborator
There was a problem hiding this comment.
Approved with one comment. this is a great start. we should use this in the new promote-release workflow to publish our sandbox as a part of things.
Member
Author
My plan exactly! 💯 |
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
nagendrareddy10
pushed a commit
to nagendrareddy10/gemini-cli
that referenced
this pull request
Sep 22, 2025
yashv6655
added a commit
to yashv6655/gemini-cli
that referenced
this pull request
Sep 22, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 2, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Package a docker container to GHCR on PRs.
Dive Deeper
Two parts:
Reviewer Test Plan
..
Testing Matrix
N/A
Linked issues / bugs
#3716