Add a version specifier to the npx command for GCP AR auth.#8653
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @cornmander, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue by pinning the version of the google-artifactregistry-auth package used in the npm run auth:npm script. By specifying a fixed version, the change aims to ensure consistent behavior and prevent potential breaking changes or unexpected issues that could arise from automatic updates to newer versions of the package, thereby improving the reliability of the authentication process.
Highlights
- Dependency Version Pinning: The
auth:npmscript inpackage.jsonnow explicitly specifies version3.4.0for thegoogle-artifactregistry-authpackage when executed vianpx.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds a version specifier to the npx command for google-artifactregistry-auth. This is a good step to ensure reproducible builds. However, I've provided a suggestion for a more robust and maintainable approach by adding google-artifactregistry-auth to the devDependencies. This will allow for better version management, make the package visible to security scanners like npm audit, and avoid hardcoding versions in scripts.
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |

Adds a version specifier to a command used in a build step.
I tested this by running
npm run authlocally.Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/752.