Allow specifying an encoding output in fromBase64#130
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables the fromBase64 function to output in a specified encoding and updates dependencies accordingly.
- Updated tests to include a custom output encoding scenario
- Modified fromBase64 to handle an optional outEncoding parameter with a default value
- Adjusted ESLint globals to recognize BufferEncoding
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/encoding.test.ts | Added a test case to verify custom encoding output functionality |
| src/encoding.ts | Updated fromBase64 to support an optional outEncoding parameter |
| eslint.config.mjs | Added BufferEncoding as a readonly global to support type checking |
Files not reviewed (1)
- package.json: Language not supported
sethvargo
force-pushed
the
sethvargo/encode_out
branch
from
435dbf5 to
613e527
Compare
sethvargo
force-pushed
the
sethvargo/encode_out
branch
from
613e527 to
024af8b
Compare
Also updates deps
sethvargo
force-pushed
the
sethvargo/encode_out
branch
from
024af8b to
37ea9e2
Compare
verbanicm
approved these changes
Apr 25, 2025
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Apr 25, 2025
## What's Changed * Allow specifying an encoding output in `fromBase64` by @sethvargo in #130 **Full Changelog**: v0.8.6...v0.8.7 --------- Co-authored-by: Seth Vargo <seth@sethvargo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates deps