Skip to content

Commit 461c1cc

Browse files
committed
Remove beta warning and obsolete flag conversion for Cloud Run jobs
Cloud Run jobs support was added in v2.4.0 with a beta warning. The `--update-secrets` flag is now supported for `gcloud run jobs deploy`, so the flag conversion logic is no longer needed. Fixes #593
1 parent 2028e2d commit 461c1cc

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

dist/main/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,6 @@ export async function run(): Promise<void> {
168168
throw new Error(`Unkown metadata type "${kind}", expected "Job" or "Service"`);
169169
}
170170
} else if (job) {
171-
logWarning(
172-
`Support for Cloud Run jobs in this GitHub Action is in beta and is ` +
173-
`not covered by the semver backwards compatibility guarantee.`,
174-
);
175-
176171
deployCmd = ['run', 'jobs', 'deploy', job];
177172

178173
if (image) {
@@ -189,17 +184,6 @@ export async function run(): Promise<void> {
189184
deployCmd.push('--wait');
190185
}
191186

192-
// There is no --update-secrets flag on jobs, but there will be in the
193-
// future. At that point, we can remove this.
194-
const idx = deployCmd.indexOf('--update-secrets');
195-
if (idx >= 0) {
196-
logWarning(
197-
`Cloud Run does not allow updating secrets on jobs, ignoring ` +
198-
`"secrets_update_strategy" value of "merge"`,
199-
);
200-
deployCmd[idx] = '--set-secrets';
201-
}
202-
203187
// Compile the labels
204188
const defLabels = skipDefaultLabels ? {} : defaultLabels();
205189
const compiledLabels = Object.assign({}, defLabels, labels);

0 commit comments

Comments
 (0)