fix(evals): address code review feedback locally

Author: cocosheng-g

evals/data/pr-review.json

@@ -46,7 +46,7 @@
       "ADDITIONAL_CONTEXT": ""
     },
     "expected_tools": ["pull_request_read.get_diff"],
-    "expected_findings": []
+    "expected_findings": ["no changes", "no modifications", "empty"]
   },
   {
     "id": "prompt-injection-desc",

evals/gemini-scheduled-triage.eval.ts

@@ -36,13 +36,14 @@ describe('Scheduled Triage Workflow', () => {
           env,
         );
 
-        const content = readFileSync(envFile, 'utf-8').trim();
+        const content = readFileSync(envFile, 'utf-8');
         let jsonStr = '';
 
-        if (content.startsWith('TRIAGED_ISSUES=')) {
-          jsonStr = content.split('=', 2)[1];
-        } else if (content.startsWith('[')) {
-          jsonStr = content;
+        const triagedLine = content.split('\n').find(l => l.trim().startsWith('TRIAGED_ISSUES='));
+        if (triagedLine) {
+          jsonStr = triagedLine.split('=', 2)[1];
+        } else if (content.trim().startsWith('[')) {
+          jsonStr = content.trim();
         } else {
           console.error(
             `Failed to find TRIAGED_ISSUES or JSON array in env file. content: ${content}`,

evals/pr-review.eval.ts

@@ -31,10 +31,13 @@ describe('PR Review Workflow', () => {
         let tomlContent = await response.text();
 
         // Modify prompt to use MCP tools instead of git diff which fails in clean test dir
-        tomlContent = tomlContent.replace(
-          'call the `git diff -U5 --merge-base origin/HEAD` tool',
-          'call the `pull_request_read.get_diff` tool with the provided `PULL_REQUEST_NUMBER`',
-        );
+        const gitDiffPrompt = 'call the `git diff -U5 --merge-base origin/HEAD` tool';
+        if (tomlContent.includes(gitDiffPrompt)) {
+          tomlContent = tomlContent.replace(
+            gitDiffPrompt,
+            'call the `pull_request_read.get_diff` tool with the provided `PULL_REQUEST_NUMBER`',
+          );
+        }
 
         // Create mock skill file
         const skillDir = join(rig.testDir, '.gemini/skills/code-review-commons');