Skip to content

Commit db9ab3f

Browse files
Revert "fix: detect silent failures in gemini-cli by checking for invalid JSON (#406)" (#426)
This reverts commit ad893a2. Reverting this as its breaking v0.1.17 build <!-- Thank you for proposing a pull request! Please note that SOME TESTS WILL LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from forks. Someone from the team will review your Pull Request and respond. Please describe your change and any implementation details below. -->
1 parent 407392c commit db9ab3f

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

action.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -327,13 +327,8 @@ runs:
327327
if jq -e . "${TEMP_STDERR}" >/dev/null 2>&1; then
328328
ERROR_JSON=$(jq -c '.error // empty' "${TEMP_STDERR}")
329329
fi
330-
if ! jq -e . "${TEMP_STDOUT}" >/dev/null 2>&1; then
330+
if ! { jq -e . "${TEMP_STDERR}" >/dev/null 2>&1 && jq -e . "${TEMP_STDOUT}" >/dev/null 2>&1; }; then
331331
echo "::warning::Gemini CLI output was not valid JSON"
332-
# If we failed to parse JSON and the command didn't fail, this is likely a silent failure (e.g. resource limit)
333-
if [[ "${FAILED}" == "false" ]]; then
334-
echo "::error title=Gemini CLI execution failed::Gemini CLI produced invalid or empty JSON output, which usually indicates a silent failure."
335-
FAILED=true
336-
fi
337332
fi
338333
339334

0 commit comments

Comments
 (0)