feat(workflow): mark workloads as failed if they hit session limit

[leehagoodjames]

Fixes: #205

[jerop]

would we need such error handling for other fatal errors? is there a way to generalize this to other fatal errors?

[jerop]

if the error message"Reached max session turns for this session" changes, then this stops working, right?

[leehagoodjames]

Yes that is correct. I see two approaches:

1. Hitting the maxSessionTurns limit causes gemini-cli to exit with a specific error code

• Pros
  • Very easy to parse downstream
• Cons
  • Likely not appropriate for all gemini-cli invocations

2. (Current behavior) Hitting the maxSessionTurns limit causes gemini-cli to exit with a 0.

• Pros
  • Does not build into gemini-cli the assumption that hitting the maxSessionTurns indicates that the workload failed
• Cons
  • Difficult for clients to reliably determine if the maxSessionTurns limit was hit, as checking the output errors requires fragile string matching

Does gemini-cli currently support any type of output that enumerates the possible reasons for ending ?

[sethvargo]

I think it would be better for the gemini-cli to publish specific exit codes for these kinds of things, no?

[jerop]

Agree, this should be an upstream change in Gemini CLI

• Robust Error Handling google-gemini/gemini-cli#6745
• Use Gemini CLI Exit Codes for Robust Error Handling #217

[gemini-cli]

📋 Review Summary

This PR adds a check to explicitly fail the action when the session turn limit is reached. This is a good improvement to the action's error handling.

🔍 General Feedback

• The approach of checking the error message is a bit brittle, but given the current limitations, it's a reasonable solution.
• The code is clear and easy to understand.
• I've added one inline comment with a suggestion for improvement.

[gemini-cli]

🟡 Using `grep` for this check is a bit fragile. If the error message changes slightly in the future, this check will fail. A more robust approach would be to use a dedicated output from the CLI to indicate this specific error condition.

Since we don't have that, we can at least make the grep more specific to avoid accidentally matching other error messages.

Suggested change

	fi
	if echo "${GEMINI_ERRORS}" | grep -q "Reached max session turns for this session"; then
	echo "::error title=Max session turns reached::The Gemini CLI session has reached its maximum number of turns and cannot continue."
	FAILED=true
	fi

[jerop]

@gemini-cli /review how can we improve the prompt?

[gemini-cli]

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

[jerop]

fyi above workflow failed because the PR is from a fork: #167

[gemini-cli]

🤖 I'm sorry @jerop, but I was unable to process your request. Please see the logs for more details.

[jerop]

Closed in favor of using error codes: #217