Fix: Add workflow name to telemetry resource attributes#493
Merged
cocosheng-g merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
cocosheng-g
requested review from
CallumHYoung,
R2wenD2,
aliciatang07 and
kkarrenn
Contributor
|
🤖 Hi @cocosheng-g, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
cocosheng-g
removed request for
CallumHYoung,
R2wenD2,
aliciatang07 and
kkarrenn
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR correctly adds the workflow name to the OpenTelemetry resource attributes in the collector configuration. This ensures that telemetry events contain the workflow context, effectively fixing the issue where it was previously missing or null in customer-triggered runs.
🔍 General Feedback
- The addition is well-integrated and consistent with existing resource attribute patterns in the configuration template.
- Leveraging the
sanitize_workflow_namestep is a good practice, ensuring that the workflow name is safe for shell command expansion and formatted correctly for telemetry purposes. - The use of
GH_WORKFLOW_NAMEacross multiple steps inaction.ymlremains consistent with the local conventions of this project.
cynthialong0-0
approved these changes
Apr 1, 2026
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Apr 24, 2026
## What's Changed * feat: expand eval dataset with edge and complex cases and refine prompts by @cocosheng-g in #458 * chore: parallelize nightly evaluations and fix suite timeouts by @cocosheng-g in #472 * docs: update an authentication documentation link by @Marukome0743 in #445 * Fix summary Markdown formatting by @Kevinrob in #474 * fix: typo workflow_name on gemini-plan-execute by @Marukome0743 in #476 * Feat: integrate code review extension in PR workflow instead of using customized review prompt by @cynthialong0-0 in #471 * feat: add GitHub Action usage metrics for telemetry by @cocosheng-g in #475 * fix: remove unused service and redundant IAM bindings in workload identity setup script by @anguillanneuf in #481 * Fix: Add workflow name to telemetry resource attributes by @cocosheng-g in #493 * fix(evals): stabilize nightly evaluation suite by @cocosheng-g in #494 * create trust guidance docs by @ehedlund in #501 ## New Contributors * @Kevinrob made their first contribution in #474 * @anguillanneuf made their first contribution in #481 * @ehedlund made their first contribution in #501 **Full Changelog**: v0.1.21...v0.1.22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the workflow name to the OpenTelemetry resource attributes in the collector configuration. This fixes the issue where GEMINI_CLI_WORKFLOW_NAME is null in metric events for customer-triggered runs. Closes #492