Skip to content

Commit 0cfd1eb

Browse files
committed
Update linters
1 parent 4b78f99 commit 0cfd1eb

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
2727
with:
28-
node-version: '20.x'
28+
node-version-file: 'package.json'
2929
registry-url: 'https://wombat-dressing-room.appspot.com/'
3030

3131
- env:

.github/workflows/unit.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,10 @@ jobs:
3131

3232
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
3333
with:
34-
node-version: '20.12.x' # https://github.com/nodejs/node/issues/53033
34+
node-version-file: 'package.json'
3535

3636
- name: 'npm build'
3737
run: 'npm ci && npm run build'
3838

39-
- name: 'npm lint'
40-
# There's no need to run the linter for each operating system, since it
41-
# will find the same thing 9x and clog up the PR review.
42-
if: ${{ matrix.os == 'ubuntu-latest' }}
43-
run: 'npm run lint'
44-
4539
- name: 'npm test'
4640
run: 'npm run test'

cmd/compile-versions/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func realMain(ctx context.Context) error {
6868
versionsMap := make(map[string]struct{}, len(names))
6969
for _, name := range names {
7070
sub := versionRe.FindStringSubmatch(name)
71-
if sub == nil || len(sub) < 2 {
71+
if len(sub) < 2 {
7272
// no match
7373
continue
7474
}

go.mod

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
module github.com/google-github-actions/setup-cloud-sdk
22

3-
go 1.22
4-
toolchain go1.24.1
3+
go 1.23.0
4+
5+
toolchain go1.24.5
56

67
require (
78
cloud.google.com/go/storage v1.40.0

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
"module": "dist/index.js",
66
"main": "dist/index.js",
77
"types": "dist/index.d.js",
8+
"engines": {
9+
"node": "20.x",
10+
"npm": "10.x"
11+
},
812
"scripts": {
913
"build": "rm -rf dist/ && ncc build --source-map --no-source-map-register src/index.ts",
1014
"lint": "eslint .",

0 commit comments

Comments
 (0)