Add an option to skip the tool-cache (#343)

It turns out that the tool-cache is adding almost a minute to every
installation (even more on Windows), when the installation itself is
only 10-20s. This introduces an option to disable the cache so we can
feed it through to the other actions.

Author: sethvargo

src/index.ts

@@ -165,7 +165,7 @@ export async function isAuthenticated(): Promise<boolean> {
  * specification is installed.
  * @returns The path of the installed tool.
  */
-export async function installGcloudSDK(version: string): Promise<string> {
+export async function installGcloudSDK(version: string, skipToolCache?: boolean): Promise<string> {
   // Retrieve the release corresponding to the specified version and OS
   const osPlat = os.platform();
   const osArch = os.arch();
@@ -180,12 +180,24 @@ export async function installGcloudSDK(version: string): Promise<string> {
     throw new Error(`Failed to download release, url: ${url}`);
   }
 
-  // Install the downloaded release into the github action env
-  const toolRoot = path.join(extPath, 'google-cloud-sdk');
-  let toolPath = await toolCache.cacheDir(toolRoot, 'gcloud', resolvedVersion);
-  toolPath = path.join(toolPath, 'bin');
-  core.addPath(toolPath);
-  return toolPath;
+  // Either cache the tool or just add it directly to the path.
+  if (skipToolCache) {
+    // Caching the tool on disk takes a really long time, and it's not clear
+    // whether it's even valuable since it's ONLY cached on disk on the runner.
+    // For GitHub-managed runners, that is useless since they are ephemeral.
+    //
+    // See https://github.com/google-github-actions/setup-gcloud/issues/701 for
+    // discussion, but it's actually faster to skip the caching and just add the
+    // tool directly to the path.
+    const toolRoot = path.join(extPath, 'google-cloud-sdk');
+    core.addPath(path.join(toolRoot, 'bin'));
+    return toolRoot;
+  } else {
+    const toolRoot = path.join(extPath, 'google-cloud-sdk');
+    const cachedToolRoot = await toolCache.cacheDir(toolRoot, 'gcloud', resolvedVersion, osArch);
+    core.addPath(path.join(cachedToolRoot, 'bin'));
+    return cachedToolRoot;
+  }
 }
 
 /**