Skip to content

Commit 481d599

Browse files
committed
Update linters
1 parent b497d55 commit 481d599

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828

2929
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
3030
with:
31-
node-version: '20.x'
31+
node-version-file: 'package.json'
3232

3333
- name: 'npm build'
3434
run: 'npm ci && npm run build'

.github/workflows/unit.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,11 @@ jobs:
3636

3737
- uses: 'actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a' # ratchet:actions/setup-node@v4
3838
with:
39-
node-version: '20.12.x' # https://github.com/nodejs/node/issues/53033
39+
node-version-file: 'package.json'
4040

4141
- name: 'npm build'
4242
run: 'npm ci && npm run build'
4343

44-
- name: 'npm lint'
45-
# There's no need to run the linter for each operating system, since it
46-
# will find the same thing 3x and clog up the PR review.
47-
if: ${{ matrix.os == 'ubuntu-latest' }}
48-
run: 'npm run lint'
49-
5044
# Only authenticate if this is a full CI run.
5145
- if: ${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name }}
5246
uses: 'google-github-actions/auth@v2' # ratchet:exclude

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
"format": "eslint . --fix",
1111
"test": "bash ./bin/runTests.sh"
1212
},
13+
"engines": {
14+
"node": "20.x",
15+
"npm": "10.x"
16+
},
1317
"repository": {
1418
"type": "git",
1519
"url": "https://github.com/google-github-actions/upload-cloud-storage"

0 commit comments

Comments
 (0)