Skip to content

Commit 7abf61a

Browse files
authored
Switch to pull non-secret values from env (#316)
1 parent b18f7f8 commit 7abf61a

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/integration.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434

3535
- uses: 'google-github-actions/auth@main'
3636
with:
37-
workload_identity_provider: '${{ secrets.WIF_PROVIDER_NAME }}'
38-
service_account: '${{ secrets.SERVICE_ACCOUNT_EMAIL }}'
37+
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
38+
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
3939

4040
- name: 'Create files'
4141
run: |-
@@ -48,7 +48,7 @@ jobs:
4848
uses: './'
4949
with:
5050
path: './test'
51-
destination: '${{ secrets.BUCKET_NAME }}/testprefix'
51+
destination: '${{ vars.BUCKET_NAME }}/testprefix'
5252

5353
- name: 'Get output'
5454
run: 'echo "${{ steps.upload.outputs.uploaded }}"'

.github/workflows/unit.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ jobs:
4848
# Only authenticate if this is a full CI run.
4949
- uses: 'google-github-actions/auth@main'
5050
with:
51-
workload_identity_provider: '${{ secrets.WIF_PROVIDER_NAME }}'
52-
service_account: '${{ secrets.SERVICE_ACCOUNT_EMAIL }}'
51+
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
52+
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
5353
if: ${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
5454

5555
# The secrets will only be injected in pushes to main or from maintainers.
5656
# If they aren't present, the associated steps are skipped.
5757
- name: 'npm test'
5858
run: 'npm run test'
5959
env:
60-
UPLOAD_CLOUD_STORAGE_TEST_BUCKET: '${{ secrets.BUCKET_NAME }}'
61-
UPLOAD_CLOUD_STORAGE_TEST_PROJECT: '${{ secrets.PROJECT_ID }}'
60+
UPLOAD_CLOUD_STORAGE_TEST_BUCKET: '${{ vars.BUCKET_NAME }}'
61+
UPLOAD_CLOUD_STORAGE_TEST_PROJECT: '${{ vars.PROJECT_ID }}'

0 commit comments

Comments
 (0)