chore: update line length to 100 to match other repos (#249)

* chore: update line length to 100 to match other repos

* Temporarily skip perf test

Author: sethvargo

.github/workflows/integration.yml

@@ -7,6 +7,7 @@ on:
   pull_request:
     branches:
     - 'main'
+  workflow_dispatch:
 
 concurrency:
   group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}'

.prettierrc.js

@@ -19,7 +19,7 @@ module.exports = {
   bracketSpacing: true,
   endOfLine: 'auto',
   jsxSingleQuote: true,
-  printWidth: 80,
+  printWidth: 100,
   quoteProps: 'consistent',
   semi: true,
   singleQuote: true,

action.yml

@@ -24,10 +24,12 @@ inputs:
     description: |-
       Upload file(s) with gzip content encoding, defaults to true.
     required: false
+    default: true
   resumable:
     description: |-
       Enable resumable uploads, defaults to true.
     required: false
+    default: true
   predefinedAcl:
     description: |-
       Apply a predefined set of access controls to the file(s).
@@ -36,6 +38,7 @@ inputs:
     description: |-
       Whether parent dir should be included in GCS destination, defaults to true.
     required: false
+    default: true
   glob:
     description: |-
       Optional glob pattern.

dist/index.js

@@ -17,12 +17,7 @@
 import * as fs from 'fs';
 import * as path from 'path';
 
-import {
-  Storage,
-  UploadResponse,
-  StorageOptions,
-  PredefinedAcl,
-} from '@google-cloud/storage';
+import { Storage, UploadResponse, StorageOptions, PredefinedAcl } from '@google-cloud/storage';
 import { parseCredential } from '@google-github-actions/actions-utils';
 import { Ignore } from 'ignore';
 

src/client.ts

@@ -43,22 +43,17 @@ function parseHeaderLines(input: string): Map<string, string> {
     const idx = line.indexOf(':');
     if (idx === -1) {
       throw new Error(
-        `Failed to parse header line ${i} ("${line}") - the expected format is ` +
-          `"key: value"`,
+        `Failed to parse header line ${i} ("${line}") - the expected format is "key: value"`,
       );
     }
 
     const key = (line.substring(0, idx) || '').trim();
     const value = (line.substring(idx + 1) || '').trim();
     if (!key) {
-      throw new Error(
-        `Failed to parse header line ${i} ("${line}") - missing key`,
-      );
+      throw new Error(`Failed to parse header line ${i} ("${line}") - missing key`);
     }
     if (!value) {
-      throw new Error(
-        `Failed to parse header line ${i} ("${line}") - missing value`,
-      );
+      throw new Error(`Failed to parse header line ${i} ("${line}") - missing value`);
     }
 
     if (map.has(key)) {

src/headers.ts

@@ -16,10 +16,7 @@
 
 import * as core from '@actions/core';
 import { PredefinedAcl } from '@google-cloud/storage';
-import {
-  errorMessage,
-  parseGcloudIgnore,
-} from '@google-github-actions/actions-utils';
+import { errorMessage, parseGcloudIgnore } from '@google-github-actions/actions-utils';
 import ignore from 'ignore';
 
 import { Client } from './client';
@@ -29,31 +26,17 @@ async function run(): Promise<void> {
   try {
     const path = core.getInput('path', { required: true });
     const destination = core.getInput('destination', { required: true });
-    const gzip =
-      core.getInput('gzip', { required: false }) === 'false' ? false : true;
-    const resumable =
-      core.getInput('resumable', { required: false }) === 'false'
-        ? false
-        : true;
-    const predefinedAclInput = core.getInput('predefinedAcl', {
-      required: false,
-    });
-    const parent =
-      core.getInput('parent', { required: false }).toLowerCase() === 'false'
-        ? false
-        : true;
+    const gzip = core.getBooleanInput('gzip');
+    const resumable = core.getBooleanInput('resumable');
+    const parent = core.getBooleanInput('parent');
     const glob = core.getInput('glob');
     const concurrency = Number(core.getInput('concurrency')) || 100;
+    const predefinedAclInput = core.getInput('predefinedAcl');
     const predefinedAcl =
-      predefinedAclInput === ''
-        ? undefined
-        : (predefinedAclInput as PredefinedAcl);
-    const headersInput = core.getInput('headers', {
-      required: false,
-    });
+      predefinedAclInput === '' ? undefined : (predefinedAclInput as PredefinedAcl);
+    const headersInput = core.getInput('headers');
     const processGcloudIgnore = core.getBooleanInput('process_gcloudignore');
-    const metadata =
-      headersInput === '' ? undefined : parseHeadersInput(headersInput);
+    const metadata = headersInput === '' ? undefined : parseHeadersInput(headersInput);
     const credentials = core.getInput('credentials');
 
     // Add warning if using credentials
@@ -87,15 +70,11 @@ async function run(): Promise<void> {
 
     core.setOutput(
       'uploaded',
-      uploadResponses
-        .map((uploadResponse) => uploadResponse[0].name)
-        .toString(),
+      uploadResponses.map((uploadResponse) => uploadResponse[0].name).toString(),
     );
   } catch (err) {
     const msg = errorMessage(err);
-    core.setFailed(
-      `google-github-actions/upload-cloud-storage failed with ${msg}`,
-    );
+    core.setFailed(`google-github-actions/upload-cloud-storage failed with: ${msg}`);
   }
 }
 

src/main.ts

@@ -18,12 +18,7 @@ import * as os from 'os';
 import * as path from 'path';
 import * as process from 'process';
 
-import {
-  PredefinedAcl,
-  Storage,
-  UploadOptions,
-  UploadResponse,
-} from '@google-cloud/storage';
+import { PredefinedAcl, Storage, UploadOptions, UploadResponse } from '@google-cloud/storage';
 import { Ignore } from 'ignore';
 import globby from 'globby';
 import * as core from '@actions/core';
@@ -102,9 +97,7 @@ export class UploadHelper {
       options.metadata = metadata;
     }
 
-    const uploadedFile = await this.storage
-      .bucket(bucketName)
-      .upload(normalizedFilePath, options);
+    const uploadedFile = await this.storage.bucket(bucketName).upload(normalizedFilePath, options);
     return uploadedFile;
   }
 
@@ -136,15 +129,8 @@ export class UploadHelper {
   ): Promise<UploadResponse[]> {
     // by default we just use directoryPath with empty glob '', which globby evaluates to directory/**/*
     const filesList = await expandGlob(directoryPath, glob);
-    const uploader = async (
-      filePath: string,
-    ): Promise<UploadResponse | null> => {
-      const destination = await getDestinationFromPath(
-        filePath,
-        directoryPath,
-        parent,
-        prefix,
-      );
+    const uploader = async (filePath: string): Promise<UploadResponse | null> => {
+      const destination = await getDestinationFromPath(filePath, directoryPath, parent, prefix);
       const uploadResp = await this.uploadFile(
         bucketName,
         filePath,
@@ -181,10 +167,7 @@ export class UploadHelper {
  * match-all pattern is used instead.
  * @return Sorted list of files in posix form.
  */
-export async function expandGlob(
-  directoryPath: string,
-  glob: string,
-): Promise<string[]> {
+export async function expandGlob(directoryPath: string, glob: string): Promise<string[]> {
   const pth = toPosixPath(path.posix.join(directoryPath, glob));
   const filesList = await globby([pth], {
     dot: true,

src/upload-helper.ts

@@ -44,11 +44,9 @@ describe('Unit Test Client', function () {
   });
 
   it('calls uploadFile', async function () {
-    const uploadFileStub = sinon
-      .stub(UploadHelper.prototype, 'uploadFile')
-      .callsFake(() => {
-        return Promise.resolve([FAKE_FILE, FAKE_METADATA]);
-      });
+    const uploadFileStub = sinon.stub(UploadHelper.prototype, 'uploadFile').callsFake(() => {
+      return Promise.resolve([FAKE_FILE, FAKE_METADATA]);
+    });
     const client = new Client();
     const filePath = './tests/testdata/test1.txt';
     const bucketName = 'foo';

tests/client.test.ts

@@ -24,10 +24,7 @@ export const EXAMPLE_FILE = './tests/testdata/test1.txt';
 export const EXAMPLE_DIR = './tests/testdata';
 export const EXAMPLE_PREFIX = 'testprefix';
 export const FAKE_METADATA = { name: 'foo' };
-export const FAKE_FILE: File = new File(
-  new Bucket(new Storage(), 'foo'),
-  'foo',
-);
+export const FAKE_FILE: File = new File(new Bucket(new Storage(), 'foo'), 'foo');
 export const FILES_IN_DIR = [
   'tests/testdata/nested1/nested2/test3.txt',
   'tests/testdata/nested1/test1.txt',
@@ -38,10 +35,7 @@ export const FILES_IN_DIR = [
   'tests/testdata/test.json',
 ];
 
-export const TXT_FILES_IN_TOP_DIR = [
-  'tests/testdata/test1.txt',
-  'tests/testdata/test2.txt',
-];
+export const TXT_FILES_IN_TOP_DIR = ['tests/testdata/test1.txt', 'tests/testdata/test2.txt'];
 
 export const TXT_FILES_IN_DIR = [
   'tests/testdata/nested1/nested2/test3.txt',