Commit d1df263
authored
Update README.md headers settable field casing (#312)
It is a bit of a gotcha that the `headers` settable fields are the
lowercase counterparts to their Header. The docs incorrectly mention the
case sensitive varitions, which when followed causes an error:
```
- uses: google-github-actions/upload-cloud-storage@v1
with:
path: /foo
destination: bucket
headers: |-
Cache-Control: public, max-age=31536000, no-transform, immutable
google-github-actions/upload-cloud-storage failed with:
invalid header key "Cache-Control" - custom header keys must be prefixed with "x-goog-meta-"
```
For future users and clarity, I think it is best to update the
documentation to use the fully lowercase versions.
Signed-off-by: Robert van Hoesel <robertvanhoesel@gmail.com>1 parent ac231a9 commit d1df263
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
245 | | - | |
| 244 | + | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
0 commit comments