Skip to content

Commit 1fc8b22

Browse files
authored
Remove wasm64_v8 test_core configuration. NFC (emscripten-core#26137)
This change is split out from emscripten-core#26131. Requiring a specific engine for test configuration like this should not be necessary and it prevents individual tests withing the test suite from then requiring a different engine (i.e. what does mean if the test suite requires v8 but specific test if marked as `@requires_node`.) Instead we can just have a single `wasm64` test suite (like we do for all other other tests suites, and the developer can choose which engine to use by editing their config.
1 parent fda71e5 commit 1fc8b22

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

test/runner.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@
9393
'lsan',
9494
'ubsan',
9595
'wasm64',
96-
'wasm64_v8',
9796
'wasm64_4gb',
9897
'esm_integration',
9998
'instance',

test/test_core.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9847,8 +9847,7 @@ def test_fcoverage_mapping(self):
98479847

98489848
# Generate tests for everything
98499849
def make_run(name, cflags=None, settings=None, env=None, # noqa
9850-
require_v8=False, v8_args=None,
9851-
require_node=False, node_args=None,
9850+
v8_args=None, node_args=None,
98529851
require_wasm64=False,
98539852
init=None):
98549853
if cflags is None:
@@ -9893,11 +9892,6 @@ def setUp(self):
98939892
if v8_args:
98949893
self.v8_args += v8_args
98959894

9896-
if require_v8:
9897-
self.require_v8()
9898-
elif require_node:
9899-
self.require_node()
9900-
99019895
if require_wasm64:
99029896
self.require_wasm64()
99039897

@@ -9931,9 +9925,7 @@ def setUp(self):
99319925

99329926
# MEMORY64=1
99339927
wasm64 = make_run('wasm64', cflags=['--profiling-funcs'],
9934-
settings={'MEMORY64': 1}, require_wasm64=True, require_node=True)
9935-
wasm64_v8 = make_run('wasm64_v8', cflags=['--profiling-funcs'],
9936-
settings={'MEMORY64': 1}, require_wasm64=True, require_v8=True)
9928+
settings={'MEMORY64': 1}, require_wasm64=True)
99379929
# Run the wasm64 tests with all memory offsets > 4gb. Be careful running this test
99389930
# suite with any kind of parallelism.
99399931
wasm64_4gb = make_run('wasm64_4gb', cflags=['--profiling-funcs'],

0 commit comments

Comments
 (0)