Merge branch 'main' into qa-report

Author: selamw1

agent_sdks/python/src/a2ui/parser/streaming.py

@@ -76,6 +76,7 @@ def __new__(cls, catalog: "A2uiCatalog" = None, *args, **kwargs):
     return super().__new__(cls)
 
   def __init__(self, catalog: "A2uiCatalog" = None):
+    self._version = getattr(catalog, "version", None) if catalog else None
     self._ref_fields_map = extract_component_ref_fields(catalog) if catalog else {}
     self._required_fields_map = (
         extract_component_required_fields(catalog) if catalog else {}
@@ -1007,11 +1008,12 @@ def traverse(obj, parent_key=None):
         ):
           path = obj["path"]
           key = path.lstrip("/")
-          if "componentId" not in obj:
-            obj.clear()
-          obj.update({"path": "/" + key})
-        else:
-          # If not in data model, still ensure path has leading slash if it's a bindable object
+          if self._version != VERSION_0_9:
+            if "componentId" not in obj:
+              obj.clear()
+            obj.update({"path": "/" + key})
+        elif self._version != VERSION_0_9:
+          # If not in data model, still ensure path has leading slash if it's a bindable object (v0.8 only)
           current_path = obj.get("path")
           if current_path is not None:
             if not isinstance(current_path, str) or not current_path.startswith("/"):

agent_sdks/python/tests/parser/test_streaming_v08.py

@@ -273,3 +273,36 @@ def test_streaming_msg_type_deduplication(mock_catalog):
 
   # After completion, msg_types is reset
   assert parser.msg_types == []
+
+
+def test_v08_path_heuristic_adds_slash(mock_catalog):
+  """Tests that v0.8 adds a leading slash to relative paths."""
+  parser = A2uiStreamParser(catalog=mock_catalog)
+  # Disable validation for simplicity
+  parser._validator = None
+
+  # 1. Send beginRendering first to avoid buffering
+  chunk_br = (
+      A2UI_OPEN_TAG
+      + '[{"beginRendering": {"surfaceId": "s1", "root": "root"}}]'
+      + A2UI_CLOSE_TAG
+  )
+  list(parser.process_chunk(chunk_br))
+
+  # 2. Send surfaceUpdate with a relative path
+  chunk_su = (
+      A2UI_OPEN_TAG
+      + '[{"surfaceUpdate": {"surfaceId": "s1", "components": [{"id": "root",'
+      ' "component": {"Text": {"text": {"path": "some/relative/path"}}}}]}}]'
+      + A2UI_CLOSE_TAG
+  )
+
+  messages = []
+  for part in parser.process_chunk(chunk_su):
+    if part.a2ui_json:
+      messages.extend(part.a2ui_json)
+
+  # The path should have been prefixed with a slash
+  assert len(messages) > 0
+  comp = messages[0][MSG_TYPE_SURFACE_UPDATE]["components"][0]
+  assert comp["component"]["Text"]["text"]["path"] == "/some/relative/path"

agent_sdks/python/tests/parser/test_streaming_v09.py

@@ -388,3 +388,67 @@ def test_streaming_msg_type_deduplication(mock_catalog):
 
   # After completion, msg_types is reset
   assert not parser.msg_types
+
+
+def test_v09_path_heuristic_relative_path(mock_catalog):
+  """Tests that v0.9 allows relative paths (no leading slash)."""
+  parser = A2uiStreamParser(catalog=mock_catalog)
+  # Disable validation to avoid needing full catalog for this test
+  parser._validator = None
+
+  # 1. Create surface
+  chunk_cs = (
+      A2UI_OPEN_TAG
+      + '[{"version": "v0.9", "createSurface": {"surfaceId": "s1", "catalogId": "c1"}}]'
+      + A2UI_CLOSE_TAG
+  )
+  list(parser.process_chunk(chunk_cs))
+
+  # 2. Update components with a relative path
+  chunk_uc = (
+      A2UI_OPEN_TAG
+      + '[{"version": "v0.9", "updateComponents": {"surfaceId": "s1", "components":'
+      ' [{"id": "root", "component": "Text", "text": {"path":'
+      ' "some/relative/path"}}]}}]'
+      + A2UI_CLOSE_TAG
+  )
+
+  messages = []
+  for part in parser.process_chunk(chunk_uc):
+    if part.a2ui_json:
+      messages.extend(part.a2ui_json)
+
+  assert len(messages) > 0
+  comp = messages[0][MSG_TYPE_UPDATE_COMPONENTS]["components"][0]
+  assert comp["text"]["path"] == "some/relative/path"
+
+
+def test_v09_path_heuristic_absolute_path(mock_catalog):
+  """Tests that v0.9 still supports absolute paths (leading slash)."""
+  parser = A2uiStreamParser(catalog=mock_catalog)
+  parser._validator = None
+
+  # 1. Create surface
+  chunk_cs = (
+      A2UI_OPEN_TAG
+      + '[{"version": "v0.9", "createSurface": {"surfaceId": "s1", "catalogId": "c1"}}]'
+      + A2UI_CLOSE_TAG
+  )
+  list(parser.process_chunk(chunk_cs))
+
+  # 2. Update components with an absolute path
+  chunk_uc = (
+      A2UI_OPEN_TAG
+      + '[{"version": "v0.9", "updateComponents": {"surfaceId": "s1", "components":'
+      ' [{"id": "root", "component": "Text", "text": {"path": "/absolute/path"}}]}}]'
+      + A2UI_CLOSE_TAG
+  )
+
+  messages = []
+  for part in parser.process_chunk(chunk_uc):
+    if part.a2ui_json:
+      messages.extend(part.a2ui_json)
+
+  assert len(messages) > 0
+  comp = messages[0][MSG_TYPE_UPDATE_COMPONENTS]["components"][0]
+  assert comp["text"]["path"] == "/absolute/path"

renderers/angular/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@a2ui/angular",
-  "version": "0.9.0-alpha.1",
+  "version": "0.9.0-alpha.3",
   "license": "Apache-2.0",
   "homepage": "https://a2ui.org/",
   "repository": {

renderers/angular/package.json

@@ -17,6 +17,7 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Component, input, signal } from '@angular/core';
 import { ButtonComponent } from './button.component';
+import { ComponentModel } from '@a2ui/web_core/v0_9';
 import { A2uiRendererService } from '../../core/a2ui-renderer.service';
 import { ComponentBinder } from '../../core/component-binder.service';
 import { By } from '@angular/platform-browser';
@@ -32,7 +33,7 @@ describe('ButtonComponent', () => {
     mockSurface = {
       dispatchAction: jasmine.createSpy('dispatchAction'),
       componentsModel: new Map([
-        ['child1', { id: 'child1', type: 'Text', properties: { text: 'Child Content' } }],
+        ['child1', new ComponentModel('child1', 'Text', { text: 'Child Content' })],
       ]),
       catalog: {
         id: 'test-catalog',

renderers/angular/src/v0_9/catalog/basic/button.component.spec.ts

@@ -17,6 +17,7 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Component, input, signal } from '@angular/core';
 import { ColumnComponent } from './column.component';
+import { ComponentModel } from '@a2ui/web_core/v0_9';
 import { A2uiRendererService } from '../../core/a2ui-renderer.service';
 import { ComponentBinder } from '../../core/component-binder.service';
 import { By } from '@angular/platform-browser';
@@ -44,9 +45,9 @@ describe('ColumnComponent', () => {
   beforeEach(async () => {
     mockSurface = {
       componentsModel: new Map([
-        ['child1', { id: 'child1', type: 'Child', properties: {} }],
-        ['child2', { id: 'child2', type: 'Child', properties: {} }],
-        ['template1', { id: 'template1', type: 'Child', properties: {} }],
+        ['child1', new ComponentModel('child1', 'Child', {})],
+        ['child2', new ComponentModel('child2', 'Child', {})],
+        ['template1', new ComponentModel('template1', 'Child', {})],
       ]),
       catalog: {
         id: 'test-catalog',
@@ -94,10 +95,9 @@ describe('ColumnComponent', () => {
 
   it('should apply flex styles from props', () => {
     fixture.detectChanges();
-    const div = fixture.debugElement.query(By.css('.a2ui-column'));
-    expect(div.styles['justify-content']).toBe('start');
-    expect(div.styles['align-items']).toBe('stretch');
-    expect(div.styles['gap']).toBe('4px');
+    const style = window.getComputedStyle(fixture.debugElement.nativeElement);
+    expect(style.justifyContent).toBe('flex-start');
+    expect(style.alignItems).toBe('stretch');
   });
 
   it('should render non-repeating children', () => {
@@ -161,7 +161,7 @@ describe('ColumnComponent', () => {
       },
     });
     fixture.detectChanges();
-    const div = fixture.debugElement.query(By.css('.a2ui-column'));
+    const div = fixture.debugElement;
     expect(div.styles['justify-content']).toBeFalsy();
     expect(div.styles['align-items']).toBeFalsy();
   });

renderers/angular/src/v0_9/catalog/basic/column.component.spec.ts

@@ -22,6 +22,7 @@ import { SliderComponent } from './slider.component';
 import { DateTimeInputComponent } from './date-time-input.component';
 import { ListComponent } from './list.component';
 import { TabsComponent } from './tabs.component';
+import { ComponentModel } from '@a2ui/web_core/v0_9';
 import { ModalComponent } from './modal.component';
 import { BoundProperty } from '../../core/types';
 import { A2uiRendererService } from '../../core/a2ui-renderer.service';
@@ -37,30 +38,12 @@ describe('Complex Components', () => {
       surfaceGroup: {
         getSurface: jasmine.createSpy('getSurface').and.returnValue({
           componentsModel: new Map([
-            [
-              'child-1',
-              { id: 'child-1', type: 'Text', properties: { text: { value: 'Child 1' } } },
-            ],
-            [
-              'child-2',
-              { id: 'child-2', type: 'Text', properties: { text: { value: 'Child 2' } } },
-            ],
-            [
-              'content-1',
-              { id: 'content-1', type: 'Text', properties: { text: { value: 'Content 1' } } },
-            ],
-            [
-              'content-2',
-              { id: 'content-2', type: 'Text', properties: { text: { value: 'Content 2' } } },
-            ],
-            [
-              'trigger-btn',
-              { id: 'trigger-btn', type: 'Text', properties: { text: { value: 'Open' } } },
-            ],
-            [
-              'modal-content',
-              { id: 'modal-content', type: 'Text', properties: { text: { value: 'Modal' } } },
-            ],
+            ['child-1', new ComponentModel('child-1', 'Text', { text: { value: 'Child 1' } })],
+            ['child-2', new ComponentModel('child-2', 'Text', { text: { value: 'Child 2' } })],
+            ['content-1', new ComponentModel('content-1', 'Text', { text: { value: 'Content 1' } })],
+            ['content-2', new ComponentModel('content-2', 'Text', { text: { value: 'Content 2' } })],
+            ['trigger-btn', new ComponentModel('trigger-btn', 'Text', { text: { value: 'Open' } })],
+            ['modal-content', new ComponentModel('modal-content', 'Text', { text: { value: 'Modal' } })],
           ]),
           catalog: {
             id: 'mock-catalog',

renderers/angular/src/v0_9/catalog/basic/complex-components.spec.ts

@@ -18,6 +18,7 @@ import { Component, input, computed, ChangeDetectionStrategy } from '@angular/co
 import { ComponentHostComponent } from '../../core/component-host.component';
 import { BoundProperty } from '../../core/types';
 import { BasicCatalogComponent } from './basic-catalog-component';
+import { Child } from '../../core/component-binder.service';
 
 /**
  * Angular implementation of the A2UI List component (v0.9).
@@ -37,7 +38,7 @@ import { BasicCatalogComponent } from './basic-catalog-component';
     @switch (listTag()) {
       @case ('ol') {
         <ol [class]="'a2ui-list ' + orientation()" [style.list-style-type]="styleType()">
-          @for (child of children(); track child.id) {
+          @for (child of children(); track trackBy($index, child)) {
             <li>
               <a2ui-v09-component-host
                 [componentKey]="child"
@@ -50,7 +51,7 @@ import { BasicCatalogComponent } from './basic-catalog-component';
       }
       @case ('ul') {
         <ul [class]="'a2ui-list ' + orientation()" [style.list-style-type]="styleType()">
-          @for (child of children(); track child.id) {
+          @for (child of children(); track trackBy($index, child)) {
             <li>
               <a2ui-v09-component-host
                 [componentKey]="child"
@@ -63,7 +64,7 @@ import { BasicCatalogComponent } from './basic-catalog-component';
       }
       @default {
         <div [class]="'a2ui-list ' + orientation()" style="list-style-type: none;">
-          @for (child of children(); track child.id) {
+          @for (child of children(); track trackBy($index, child)) {
             <div class="a2ui-list-item-none">
               <a2ui-v09-component-host
                 [componentKey]="child"
@@ -123,8 +124,6 @@ export class ListComponent extends BasicCatalogComponent {
     return Array.isArray(raw) ? raw : [];
   });
 
-
-
   listTag = computed(() => {
     const style = this.listStyle();
     if (style === 'ordered') return 'ol';
@@ -137,4 +136,10 @@ export class ListComponent extends BasicCatalogComponent {
     if (style === 'none') return 'none';
     return '';
   });
+
+  /**
+   * Track-by function to ensure stable change detection for list items.
+   * Uses the full resolved path (`basePath/id`) to uniquely identify items.
+   */
+  readonly trackBy = (index: number, item: Child) => `${item.basePath}/${item.id}`;
 }

renderers/angular/src/v0_9/catalog/basic/list.component.ts

@@ -17,6 +17,7 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Component, input, signal } from '@angular/core';
 import { RowComponent } from './row.component';
+import { ComponentModel } from '@a2ui/web_core/v0_9';
 import { A2uiRendererService } from '../../core/a2ui-renderer.service';
 import { ComponentBinder } from '../../core/component-binder.service';
 import { By } from '@angular/platform-browser';
@@ -44,9 +45,9 @@ describe('RowComponent', () => {
   beforeEach(async () => {
     mockSurface = {
       componentsModel: new Map([
-        ['child1', { id: 'child1', type: 'Child', properties: {} }],
-        ['child2', { id: 'child2', type: 'Child', properties: {} }],
-        ['template1', { id: 'template1', type: 'Child', properties: {} }],
+        ['child1', new ComponentModel('child1', 'Child', {})],
+        ['child2', new ComponentModel('child2', 'Child', {})],
+        ['template1', new ComponentModel('template1', 'Child', {})],
       ]),
       catalog: {
         id: 'test-catalog',
@@ -94,10 +95,9 @@ describe('RowComponent', () => {
 
   it('should apply flex styles from props', () => {
     fixture.detectChanges();
-    const div = fixture.debugElement.query(By.css('.a2ui-row'));
-    expect(div.styles['justify-content']).toBe('center');
-    expect(div.styles['align-items']).toBe('baseline');
-    expect(div.styles['gap']).toBe('4px');
+    const style = window.getComputedStyle(fixture.debugElement.nativeElement);
+    expect(style.justifyContent).toBe('center');
+    expect(style.alignItems).toBe('baseline');
   });
 
   it('should render non-repeating children', () => {
@@ -161,7 +161,7 @@ describe('RowComponent', () => {
       },
     });
     fixture.detectChanges();
-    const div = fixture.debugElement.query(By.css('.a2ui-row'));
+    const div = fixture.debugElement;
     expect(div.styles['justify-content']).toBeFalsy();
     expect(div.styles['align-items']).toBeFalsy();
   });