The React renderer's build script uses tsup, which wraps esbuild for speed but does not typecheck. A separate typecheck script exists but was not wired into build or CI, so type errors could(and did) land on main unnoticed.
For example, in this bit of testing code we see imports to node utilities, but the tsconfig of the project doesn't include the typings for node:
|
import fs from 'fs'; |
|
import path from 'path'; |
The result is that running npm run typecheck fails with errors. This surprised me because this was code already checked in upstream, which signaled to me that the build/run commands weren't running typechecking.
The React renderer's build script uses
tsup, which wraps esbuild for speed but does not typecheck. A separatetypecheckscript exists but was not wired into build or CI, so type errors could(and did) land on main unnoticed.For example, in this bit of testing code we see imports to node utilities, but the tsconfig of the project doesn't include the typings for node:
A2UI/renderers/react/tests/v0_9/basic-catalog-examples.test.tsx
Lines 22 to 23 in 6ec39d8
The result is that running
npm run typecheckfails with errors. This surprised me because this was code already checked in upstream, which signaled to me that the build/run commands weren't running typechecking.