feat(eval): add CI workflow for A2UI evaluations#1350
Closed
gspencergoog wants to merge 0 commit intogoogle:mainfrom
Closed
feat(eval): add CI workflow for A2UI evaluations#1350gspencergoog wants to merge 0 commit intogoogle:mainfrom
gspencergoog wants to merge 0 commit intogoogle:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces a bash script with a Python-based CI evaluation script, run_ci_evals.py. The new script automates running evaluations via inspect, calculates accuracy from the resulting logs, and enforces a pass threshold. Feedback from the review includes fixing a potential NoneType error in argument parsing, ensuring consistent seed generation by using UTC time, allowing the model name to be configured via environment variables, and using modification time for more reliable log file discovery.
gspencergoog
force-pushed
the
evals_ci
branch
3 times, most recently
from
bc75b24 to
c04e552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_ci_evals.pyto run evals with daily shuffle and limit.pass_percentagelogic intorun_ci_evals.pyto removejqdependency.pass_percentagescript..github/workflows/run_evals.ymlto run evals on PR and push to main with an 85% threshold.