Skip to content

Commit 0154b3b

Browse files
committed
changes from review
1 parent 5daf3a4 commit 0154b3b

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

GoogleSignIn/Sources/GIDSignIn.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
#import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDProfileData.h"
2222
#import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignInResult.h"
2323

24+
#import "GoogleSignIn/Sources/GIDAuthStateMigration.h"
2425
#import "GoogleSignIn/Sources/GIDEMMSupport.h"
2526
#import "GoogleSignIn/Sources/GIDSignInInternalOptions.h"
2627
#import "GoogleSignIn/Sources/GIDSignInPreferences.h"
2728
#import "GoogleSignIn/Sources/GIDCallbackQueue.h"
2829
#import "GoogleSignIn/Sources/GIDScopes.h"
2930
#import "GoogleSignIn/Sources/GIDSignInCallbackSchemes.h"
30-
#import "GoogleSignIn/Sources/GIDAuthStateMigration.h"
3131
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
3232
#import <AppCheckCore/GACAppCheckToken.h>
3333
#import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h"

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ - (void)setUp {
102102
GTMKeychainAttribute *fileBasedKeychain = [GTMKeychainAttribute useFileBasedKeychain];
103103
NSSet *attributes = [NSSet setWithArray:@[fileBasedKeychain]];
104104
_realLegacyGTMKeychainStore = [[GTMKeychainStore alloc] initWithItemName:kKeychainName
105-
keychainAttributes:attributes];
105+
keychainAttributes:attributes];
106106
#endif
107107
}
108108

@@ -147,7 +147,7 @@ - (void)testMigrateIfNeeded_NoPreviousMigration {
147147
[_realLegacyGTMKeychainStore saveAuthSession:authSession error:&err];
148148
XCTAssertNil(err);
149149
#else
150-
[self setUpCommonExtractAuthorizationMocksWithFingerPrint:kSavedFingerprint];
150+
[self setUpCommonExtractAuthorizationMocksWithFingerPrint:kSavedFingerprint];
151151
#endif
152152

153153
GIDAuthStateMigration *migration =
@@ -189,7 +189,7 @@ - (void)testMigrateIfNeeded_KeychainFailure {
189189
[_realLegacyGTMKeychainStore saveAuthSession:authSession error:&err];
190190
XCTAssertNil(err);
191191
#else
192-
[self setUpCommonExtractAuthorizationMocksWithFingerPrint:kSavedFingerprint];
192+
[self setUpCommonExtractAuthorizationMocksWithFingerPrint:kSavedFingerprint];
193193
#endif
194194

195195
GIDAuthStateMigration *migration =

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ Google Sign-In allows your users to sign-in to your native macOS app using their
4848
and default browser. When building for macOS, the `signInWithConfiguration:` and `addScopes:`
4949
methods take a `presentingWindow:` parameter in place of `presentingViewController:`. Note that
5050
in order for your macOS app to store credentials via the Keychain on macOS, you will need to add
51-
`$(AppIdentifierPrefix)$(CFBundleIdentifier)` to their keychain access group.
51+
`$(AppIdentifierPrefix)$(CFBundleIdentifier)` to its keychain access group.
5252

5353
### Mac Catalyst
5454

5555
Google Sign-In also supports iOS apps that are built for macOS via
5656
[Mac Catalyst](https://developer.apple.com/mac-catalyst/). In order for your Mac Catalyst app
5757
to store credentials via the Keychain on macOS, you will need to add
58-
`$(AppIdentifierPrefix)$(CFBundleIdentifier)` to their keychain access group.
58+
`$(AppIdentifierPrefix)$(CFBundleIdentifier)` to its keychain access group.
5959

6060
## Using the Google Sign-In Button
6161

0 commit comments

Comments
 (0)