Refactor Github Action per b/485167538 (#581)

google-admin · benknutson-google · web-flow · commit 20ec940d05f1 · 2026-02-17T20:40:22.000-08:00
Co-authored-by: Ben Knutson &lt;benknutson@google.com&gt;
diff --git a/.github/workflows/pr_notification.yml b/.github/workflows/pr_notification.yml
@@ -10,8 +10,11 @@ jobs:
     steps:
     - name: Pull Request Details
       run: |
-        echo "Pull Request: ${{ github.event.pull_request.title }}"
-        echo "Author: ${{ github.event.pull_request.user.login }}"
+        echo "Pull Request: ${GITHUB_EVENT_PULL_REQUEST_TITLE}"
+        echo "Author: ${GITHUB_EVENT_PULL_REQUEST_USER_LOGIN}"
+      env:
+        GITHUB_EVENT_PULL_REQUEST_TITLE: ${{ github.event.pull_request.title }}
+        GITHUB_EVENT_PULL_REQUEST_USER_LOGIN: ${{ github.event.pull_request.user.login }}
 
     - name: Google Chat Notification
       run: |
@@ -30,19 +33,19 @@ jobs:
                     {
                       "keyValue": {
                         "topLabel": "Repo",
-                        "content": "${{ github.event.pull_request.head.repo.full_name }}"
+                        "content": "${GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME}"
                       }
                     },
                     {
                       "keyValue": {
                         "topLabel": "Title",
-                        "content": "${{ github.event.pull_request.title }}"
+                        "content": "${GITHUB_EVENT_PULL_REQUEST_TITLE}"
                       }
                     },
                     {
                       "keyValue": {
                         "topLabel": "Creator",
-                        "content": "${{ github.event.pull_request.user.login }}"
+                        "content": "${GITHUB_EVENT_PULL_REQUEST_USER_LOGIN}"
                       }
                     },
                     {
@@ -76,7 +79,7 @@ jobs:
                             "text": "Open Pull Request",
                             "onClick": {
                               "openLink": {
-                                "url": "${{ github.event.pull_request.html_url }}"
+                                "url": "${GITHUB_EVENT_PULL_REQUEST_HTML_URL}"
                               }
                             }
                           }
@@ -89,3 +92,8 @@ jobs:
             }
           ]
         }'
+      env:
+        GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
+        GITHUB_EVENT_PULL_REQUEST_TITLE: ${{ github.event.pull_request.title }}
+        GITHUB_EVENT_PULL_REQUEST_USER_LOGIN: ${{ github.event.pull_request.user.login }}
+        GITHUB_EVENT_PULL_REQUEST_HTML_URL: ${{ github.event.pull_request.html_url }}
diff --git a/.github/workflows/push_notification.yml b/.github/workflows/push_notification.yml
@@ -12,8 +12,11 @@ jobs:
     - name: Main Branch Push
       run: |
         echo "Workflow initiated by event with name: ${{ github.event_name }}"
-        echo "Pushing commit to main: ${{ github.event.head_commit.id }}"
-        echo "Pushed by: ${{ github.event.pusher.name }}"
+        echo "Pushing commit to main: ${GITHUB_EVENT_HEAD_COMMIT_ID}"
+        echo "Pushed by: ${GITHUB_EVENT_PUSHER_NAME}"
+      env:
+        GITHUB_EVENT_HEAD_COMMIT_ID: ${{ github.event.head_commit.id }}
+        GITHUB_EVENT_PUSHER_NAME: ${{ github.event.pusher.name }}
 
     - name: Push Notification to Google Chat
       run: |
@@ -24,21 +27,21 @@ jobs:
             {
               "header": {
                 "title": "Push to main branch",
-                "subtitle": "${{ github.event.head_commit.message }}"
+                "subtitle": "${GITHUB_EVENT_HEAD_COMMIT_MESSAGE}"
               },
               "sections": [
                 {
                   "widgets": [
                     {
                       "keyValue": {
                         "topLabel": "Repo",
-                        "content": "${{ github.event.repository.full_name }}"
+                        "content": "${GITHUB_EVENT_REPOSITORY_FULL_NAME}"
                       }
                     },
                     {
                       "keyValue": {
                         "topLabel": "Committed by",
-                        "content": "${{ github.event.head_commit.author.username }}"
+                        "content": "${GITHUB_EVENT_HEAD_COMMIT_AUTHOR_USERNAME}"
                       }
                     },
                     {
@@ -48,7 +51,7 @@ jobs:
                             "text": "Ref comparison",
                             "onClick": {
                               "openLink": {
-                                "url": "${{ github.event.compare }}"
+                                "url": "${GITHUB_EVENT_COMPARE}"
                               }
                             }
                           }
@@ -61,4 +64,9 @@ jobs:
             }
           ]
         }'
+      env:
+        GITHUB_EVENT_HEAD_COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
+        GITHUB_EVENT_REPOSITORY_FULL_NAME: ${{ github.event.repository.full_name }}
+        GITHUB_EVENT_HEAD_COMMIT_AUTHOR_USERNAME: ${{ github.event.head_commit.author.username }}
+        GITHUB_EVENT_COMPARE: ${{ github.event.compare }}
 

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,11 @@ jobs:`
`10`	`10`	`steps:`
`11`	`11`	`- name: Pull Request Details`
`12`	`12`	`run: \|`
`13`		`- echo "Pull Request: ${{ github.event.pull_request.title }}"`
`14`		`- echo "Author: ${{ github.event.pull_request.user.login }}"`
	`13`	`+ echo "Pull Request: ${GITHUB_EVENT_PULL_REQUEST_TITLE}"`
	`14`	`+ echo "Author: ${GITHUB_EVENT_PULL_REQUEST_USER_LOGIN}"`
	`15`	`+ env:`
	`16`	`+ GITHUB_EVENT_PULL_REQUEST_TITLE: ${{ github.event.pull_request.title }}`
	`17`	`+ GITHUB_EVENT_PULL_REQUEST_USER_LOGIN: ${{ github.event.pull_request.user.login }}`
`15`	`18`
`16`	`19`	`- name: Google Chat Notification`
`17`	`20`	`run: \|`
`@@ -30,19 +33,19 @@ jobs:`
`30`	`33`	`{`
`31`	`34`	`"keyValue": {`
`32`	`35`	`"topLabel": "Repo",`
`33`		`- "content": "${{ github.event.pull_request.head.repo.full_name }}"`
	`36`	`+ "content": "${GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME}"`
`34`	`37`	`}`
`35`	`38`	`},`
`36`	`39`	`{`
`37`	`40`	`"keyValue": {`
`38`	`41`	`"topLabel": "Title",`
`39`		`- "content": "${{ github.event.pull_request.title }}"`
	`42`	`+ "content": "${GITHUB_EVENT_PULL_REQUEST_TITLE}"`
`40`	`43`	`}`
`41`	`44`	`},`
`42`	`45`	`{`
`43`	`46`	`"keyValue": {`
`44`	`47`	`"topLabel": "Creator",`
`45`		`- "content": "${{ github.event.pull_request.user.login }}"`
	`48`	`+ "content": "${GITHUB_EVENT_PULL_REQUEST_USER_LOGIN}"`
`46`	`49`	`}`
`47`	`50`	`},`
`48`	`51`	`{`
`@@ -76,7 +79,7 @@ jobs:`
`76`	`79`	`"text": "Open Pull Request",`
`77`	`80`	`"onClick": {`
`78`	`81`	`"openLink": {`
`79`		`- "url": "${{ github.event.pull_request.html_url }}"`
	`82`	`+ "url": "${GITHUB_EVENT_PULL_REQUEST_HTML_URL}"`
`80`	`83`	`}`
`81`	`84`	`}`
`82`	`85`	`}`
`@@ -89,3 +92,8 @@ jobs:`
`89`	`92`	`}`
`90`	`93`	`]`
`91`	`94`	`}'`
	`95`	`+ env:`
	`96`	`+ GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}`
	`97`	`+ GITHUB_EVENT_PULL_REQUEST_TITLE: ${{ github.event.pull_request.title }}`
	`98`	`+ GITHUB_EVENT_PULL_REQUEST_USER_LOGIN: ${{ github.event.pull_request.user.login }}`
	`99`	`+ GITHUB_EVENT_PULL_REQUEST_HTML_URL: ${{ github.event.pull_request.html_url }}`
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,11 @@ jobs:`
`12`	`12`	`- name: Main Branch Push`
`13`	`13`	`run: \|`
`14`	`14`	`echo "Workflow initiated by event with name: ${{ github.event_name }}"`
`15`		`- echo "Pushing commit to main: ${{ github.event.head_commit.id }}"`
`16`		`- echo "Pushed by: ${{ github.event.pusher.name }}"`
	`15`	`+ echo "Pushing commit to main: ${GITHUB_EVENT_HEAD_COMMIT_ID}"`
	`16`	`+ echo "Pushed by: ${GITHUB_EVENT_PUSHER_NAME}"`
	`17`	`+ env:`
	`18`	`+ GITHUB_EVENT_HEAD_COMMIT_ID: ${{ github.event.head_commit.id }}`
	`19`	`+ GITHUB_EVENT_PUSHER_NAME: ${{ github.event.pusher.name }}`
`17`	`20`
`18`	`21`	`- name: Push Notification to Google Chat`
`19`	`22`	`run: \|`
`@@ -24,21 +27,21 @@ jobs:`
`24`	`27`	`{`
`25`	`28`	`"header": {`
`26`	`29`	`"title": "Push to main branch",`
`27`		`- "subtitle": "${{ github.event.head_commit.message }}"`
	`30`	`+ "subtitle": "${GITHUB_EVENT_HEAD_COMMIT_MESSAGE}"`
`28`	`31`	`},`
`29`	`32`	`"sections": [`
`30`	`33`	`{`
`31`	`34`	`"widgets": [`
`32`	`35`	`{`
`33`	`36`	`"keyValue": {`
`34`	`37`	`"topLabel": "Repo",`
`35`		`- "content": "${{ github.event.repository.full_name }}"`
	`38`	`+ "content": "${GITHUB_EVENT_REPOSITORY_FULL_NAME}"`
`36`	`39`	`}`
`37`	`40`	`},`
`38`	`41`	`{`
`39`	`42`	`"keyValue": {`
`40`	`43`	`"topLabel": "Committed by",`
`41`		`- "content": "${{ github.event.head_commit.author.username }}"`
	`44`	`+ "content": "${GITHUB_EVENT_HEAD_COMMIT_AUTHOR_USERNAME}"`
`42`	`45`	`}`
`43`	`46`	`},`
`44`	`47`	`{`
`@@ -48,7 +51,7 @@ jobs:`
`48`	`51`	`"text": "Ref comparison",`
`49`	`52`	`"onClick": {`
`50`	`53`	`"openLink": {`
`51`		`- "url": "${{ github.event.compare }}"`
	`54`	`+ "url": "${GITHUB_EVENT_COMPARE}"`
`52`	`55`	`}`
`53`	`56`	`}`
`54`	`57`	`}`
`@@ -61,4 +64,9 @@ jobs:`
`61`	`64`	`}`
`62`	`65`	`]`
`63`	`66`	`}'`
	`67`	`+ env:`
	`68`	`+ GITHUB_EVENT_HEAD_COMMIT_MESSAGE: ${{ github.event.head_commit.message }}`
	`69`	`+ GITHUB_EVENT_REPOSITORY_FULL_NAME: ${{ github.event.repository.full_name }}`
	`70`	`+ GITHUB_EVENT_HEAD_COMMIT_AUTHOR_USERNAME: ${{ github.event.head_commit.author.username }}`
	`71`	`+ GITHUB_EVENT_COMPARE: ${{ github.event.compare }}`
`64`	`72`