Skip to content

Commit 3c02be4

Browse files
committed
Removed nil from error initialization in GIDTokenClaimsInternalOptionsTest
1 parent c7a7fb5 commit 3c02be4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

GoogleSignIn/Sources/GIDJSONSerializer/Implementation/GIDJSONSerializerImpl.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ @implementation GIDJSONSerializerImpl
2525

2626
- (nullable NSString *)stringWithJSONObject:(NSDictionary<NSString *, id> *)jsonObject
2727
error:(NSError *_Nullable *_Nullable)error {
28-
NSError *serializationError = nil;
28+
NSError *serializationError;
2929
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:jsonObject
3030
options:0
3131
error:&serializationError];

GoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ - (void)testValidatedJSONStringForClaims_WithEmptyInput_ShouldReturnNil {
5555

5656
- (void)testValidatedJSONStringForClaims_WithNonEssentialClaim_IsCorrectlyFormatted {
5757
NSSet *claims = [NSSet setWithObject:[GIDTokenClaim authTimeClaim]];
58-
NSError *error = nil;
58+
NSError *error;
5959
NSString *result = [_tokenClaimsInternalOptions validatedJSONStringForClaims:claims error:&error];
6060

6161
XCTAssertNil(error);
@@ -64,7 +64,7 @@ - (void)testValidatedJSONStringForClaims_WithNonEssentialClaim_IsCorrectlyFormat
6464

6565
- (void)testValidatedJSONStringForClaims_WithEssentialClaim_IsCorrectlyFormatted {
6666
NSSet *claims = [NSSet setWithObject:[GIDTokenClaim essentialAuthTimeClaim]];
67-
NSError *error = nil;
67+
NSError *error;
6868
NSString *result = [_tokenClaimsInternalOptions validatedJSONStringForClaims:claims error:&error];
6969

7070
XCTAssertNil(error);
@@ -91,7 +91,7 @@ - (void)testValidatedJSONStringForClaims_WhenSerializationFails_ReturnsNilAndErr
9191
NSSet *claims = [NSSet setWithObject:[GIDTokenClaim authTimeClaim]];
9292
NSError *expectedJSONError = [NSError errorWithDomain:@"com.fake.json" code:-999 userInfo:nil];
9393
_jsonSerializerFake.errorToReturn = expectedJSONError;
94-
NSError *actualError = nil;
94+
NSError *actualError;
9595
NSString *result =
9696
[_tokenClaimsInternalOptions validatedJSONStringForClaims:claims error:&actualError];
9797

0 commit comments

Comments
 (0)