Skip to content

Commit 521e246

Browse files
authored
Update AppAuth dependency minimum to 2.1.0 (#603)
Note: Integration tests skipped, manually verified.
1 parent 02616ac commit 521e246

6 files changed

Lines changed: 13 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Unreleased
2+
- Update the AppAuth-iOS dependency to version 2.1.0 ([#954](https://github.com/openid/AppAuth-iOS/pull/954), [#955](https://github.com/openid/AppAuth-iOS/pull/955))
3+
14
# 9.1.0
25
- Allow requesting `claims` (currently, only `auth_time`) via [Sign-in methods](https://github.com/google/GoogleSignIn-iOS/blob/gandhiakshat/update-changelog-for-9.1.0-release/GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h#L240) ([#550](https://github.com/google/GoogleSignIn-iOS/pull/550), [#552](https://github.com/google/GoogleSignIn-iOS/pull/552), [#553](https://github.com/google/GoogleSignIn-iOS/pull/553), [#569](https://github.com/google/GoogleSignIn-iOS/pull/569))
36
- Update `addScopes:` methods in `GIDSignIn` to include previously requested `claims` ([#557](https://github.com/google/GoogleSignIn-iOS/pull/557))

GoogleSignIn.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th
3434
s.ios.framework = 'UIKit'
3535
s.osx.framework = 'AppKit'
3636
s.dependency 'AppCheckCore', '~> 11.0'
37-
s.dependency 'AppAuth', '~> 2.0'
37+
s.dependency 'AppAuth', '~> 2.1'
3838
s.dependency 'GTMAppAuth', '~> 5.0'
3939
s.dependency 'GTMSessionFetcher/Core', '~> 3.3'
4040
s.resource_bundle = {

GoogleSignIn/Sources/GIDSignIn.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ @implementation GIDSignIn {
201201
- (BOOL)handleURL:(NSURL *)url {
202202
// Check if the callback path matches the expected one for a URL from Safari/Chrome/SafariVC.
203203
if ([url.path isEqual:kBrowserCallbackPath]) {
204-
if ([_currentAuthorizationFlow resumeExternalUserAgentFlowWithURL:url]) {
204+
if ([_currentAuthorizationFlow resumeExternalUserAgentFlowWithURL:url error:nil]) {
205205
_currentAuthorizationFlow = nil;
206206
return YES;
207207
}

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ let package = Package(
4343
dependencies: [
4444
.package(
4545
url: "https://github.com/openid/AppAuth-iOS.git",
46-
from: "2.0.0"),
46+
from: "2.1.0"),
4747
.package(
4848
url: "https://github.com/google/app-check.git",
4949
from: "11.0.0"),

Package@swift-5.5.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ let package = Package(
4444
.package(
4545
name: "AppAuth",
4646
url: "https://github.com/openid/AppAuth-iOS.git",
47-
from: "2.0.0"),
47+
from: "2.1.0"),
4848
.package(
4949
name: "AppCheck",
5050
url: "https://github.com/google/app-check.git",

Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
736F49BC270E102C00580053 /* BirthdayViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 736F49BB270E102C00580053 /* BirthdayViewModel.swift */; };
2323
739FCC46270E467600C92042 /* BirthdayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 739FCC45270E467600C92042 /* BirthdayView.swift */; };
2424
739FCC48270E659A00C92042 /* Birthday.swift in Sources */ = {isa = PBXBuildFile; fileRef = 739FCC47270E659A00C92042 /* Birthday.swift */; };
25+
F8CE6602270E659A00C92042 /* Claim.swift in Sources */ = {isa = PBXBuildFile; fileRef = F8CE6601270E659A00C92042 /* Claim.swift */; };
2526
73DB41892805FBA90028B8D3 /* DaysUntilBirthday.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7345AD022703D9470020AFB1 /* DaysUntilBirthday.swift */; };
2627
73DB418A2805FBC00028B8D3 /* GoogleSignInAuthenticator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7345AD172703D9C30020AFB1 /* GoogleSignInAuthenticator.swift */; };
2728
73DB418B2805FBC40028B8D3 /* BirthdayLoader.swift in Sources */ = {isa = PBXBuildFile; fileRef = 736F49B9270E05E200580053 /* BirthdayLoader.swift */; };
@@ -34,6 +35,7 @@
3435
73DB41922805FC010028B8D3 /* UserProfileImageView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7345AD142703D9C30020AFB1 /* UserProfileImageView.swift */; };
3536
73DB41932805FC3B0028B8D3 /* UserProfileView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FE7173A527F5110F00910319 /* UserProfileView.swift */; };
3637
73DB41952805FC5F0028B8D3 /* Birthday.swift in Sources */ = {isa = PBXBuildFile; fileRef = 739FCC47270E659A00C92042 /* Birthday.swift */; };
38+
F8CE66032805FC5F0028B8D3 /* Claim.swift in Sources */ = {isa = PBXBuildFile; fileRef = F8CE6601270E659A00C92042 /* Claim.swift */; };
3739
73DB419628060A9A0028B8D3 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 7345AD062703D9480020AFB1 /* Assets.xcassets */; };
3840
C1B5D38D282AFE870068D12B /* README.md in Resources */ = {isa = PBXBuildFile; fileRef = C1B5D38C282AFE870068D12B /* README.md */; };
3941
EEEEE201864437604E97D3B4 /* Pods_DaysUntilBirthdayForPod__iOS_.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F329EC9CE4A0A4AF2280834F /* Pods_DaysUntilBirthdayForPod__iOS_.framework */; };
@@ -61,6 +63,7 @@
6163
736F49BB270E102C00580053 /* BirthdayViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BirthdayViewModel.swift; sourceTree = "<group>"; };
6264
739FCC45270E467600C92042 /* BirthdayView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BirthdayView.swift; sourceTree = "<group>"; };
6365
739FCC47270E659A00C92042 /* Birthday.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Birthday.swift; sourceTree = "<group>"; };
66+
F8CE6601270E659A00C92042 /* Claim.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Claim.swift; sourceTree = "<group>"; };
6467
7542DB53C46DFA9B71387188 /* Pods-DaysUntilBirthdayForPod (iOS).release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-DaysUntilBirthdayForPod (iOS).release.xcconfig"; path = "Target Support Files/Pods-DaysUntilBirthdayForPod (iOS)/Pods-DaysUntilBirthdayForPod (iOS).release.xcconfig"; sourceTree = "<group>"; };
6568
926A15D393D684C68E09FB0F /* Pods_DaysUntilBirthdayForPod__macOS_.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_DaysUntilBirthdayForPod__macOS_.framework; sourceTree = BUILT_PRODUCTS_DIR; };
6669
B7CC09BA1B68EB1881A08E87 /* Pods-DaysUntilBirthdayForPod(macOS).debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-DaysUntilBirthdayForPod(macOS).debug.xcconfig"; path = "Target Support Files/Pods-DaysUntilBirthdayForPod(macOS)/Pods-DaysUntilBirthdayForPod(macOS).debug.xcconfig"; sourceTree = "<group>"; };
@@ -205,6 +208,7 @@
205208
isa = PBXGroup;
206209
children = (
207210
739FCC47270E659A00C92042 /* Birthday.swift */,
211+
F8CE6601270E659A00C92042 /* Claim.swift */,
208212
);
209213
path = Models;
210214
sourceTree = "<group>";
@@ -413,6 +417,7 @@
413417
buildActionMask = 2147483647;
414418
files = (
415419
739FCC48270E659A00C92042 /* Birthday.swift in Sources */,
420+
F8CE6602270E659A00C92042 /* Claim.swift in Sources */,
416421
739FCC46270E467600C92042 /* BirthdayView.swift in Sources */,
417422
7345AD1B2703D9C30020AFB1 /* SignInView.swift in Sources */,
418423
7345AD212703D9C30020AFB1 /* GoogleSignInAuthenticator.swift in Sources */,
@@ -438,6 +443,7 @@
438443
73DB418C2805FBC80028B8D3 /* UserProfileImageLoader.swift in Sources */,
439444
73DB418E2805FBD40028B8D3 /* BirthdayViewModel.swift in Sources */,
440445
73DB41952805FC5F0028B8D3 /* Birthday.swift in Sources */,
446+
F8CE66032805FC5F0028B8D3 /* Claim.swift in Sources */,
441447
73DB418A2805FBC00028B8D3 /* GoogleSignInAuthenticator.swift in Sources */,
442448
73DB41932805FC3B0028B8D3 /* UserProfileView.swift in Sources */,
443449
73DB41892805FBA90028B8D3 /* DaysUntilBirthday.swift in Sources */,

0 commit comments

Comments
 (0)