Removed the support for handling nested containers in GIDEMMSupport.m

Author: AkshatG6

GoogleSignIn/Sources/GIDEMMSupport.m

@@ -161,20 +161,10 @@ - (void)updateErrorForAuthSession:(GTMAuthSession *)authSession
       return;
     }
 
-    // Case 3: The value is of `NSArray` or `NSDictionary` type.
-    // To satisfy `GTMAppAuth`'s requirement for `NSDictionary<NSString *, NSString *>` parameter,
-    // the entire value object is serialized into a single `JSON` string.
-    if ([NSJSONSerialization isValidJSONObject:value]) {
-      NSError *error = nil;
-      NSData *jsonData = [NSJSONSerialization dataWithJSONObject:value options:0 error:&error];
-
-      if (jsonData && !error) {
-        stringifiedDictionary[key] = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
-      } else {
-        stringifiedDictionary[key] = [value description];
-      }
-      return;
-    }
+    // NOTE: Nested container objects (e.g., NSArray, NSDictionary) are intentionally ignored.
+    // The underlying AppAuth API expects a flat `NSDictionary<NSString *, NSString *>` and is
+    // not designed for serialized, nested objects. A proper fix for nested objects
+    // would require a larger refactoring of the AppAuth and GTMAppAuth libraries.
   }];
   return stringifiedDictionary;
 }

GoogleSignIn/Tests/Unit/GIDEMMSupportTest.m

@@ -353,74 +353,6 @@ - (void)testStringConversion_withString_remainsUnchanged {
                         @"The original string value should be preserved.");
 }
 
-- (void)testStringConversion_withArray_isConvertedToJSONString {
-  NSDictionary *inputDictionary = @{
-    @"array_key": @[ @1, @"two", @YES ]
-  };
-
-  NSDictionary *resultDictionary = [GIDEMMSupport
-                                    dictionaryWithStringValuesFromDictionary:inputDictionary];
-
-  XCTAssertTrue([resultDictionary[@"array_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"array_key"], @"[1,\"two\",true]",
-                        @"The array should be serialized into a JSON string.");
-}
-
-- (void)testStringConversion_withDictionary_isConvertedToJSONString {
-  NSDictionary *inputDictionary = @{
-    @"dict_key": @{
-      @"nested_key": @"nested_value"
-    }
-  };
-
-  NSDictionary *resultDictionary = [GIDEMMSupport
-                                    dictionaryWithStringValuesFromDictionary:inputDictionary];
-
-  XCTAssertTrue([resultDictionary[@"dict_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"dict_key"], @"{\"nested_key\":\"nested_value\"}",
-                        @"The dictionary should be serialized into a JSON string.");
-}
-
-- (void)testStringConversion_withMixedTypes_allAreConverted {
-  NSDictionary *inputDictionary = @{
-    @"string_key": @"hello",
-    @"number_key": @987,
-    @"bool_key": @YES,
-    @"array_key": @[ @"a", @NO ],
-  };
-
-  NSDictionary *resultDictionary = [GIDEMMSupport
-                                    dictionaryWithStringValuesFromDictionary:inputDictionary];
-
-  XCTAssertTrue([resultDictionary[@"string_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"string_key"], @"hello",
-                        @"The original string value should be preserved");
-
-  XCTAssertTrue([resultDictionary[@"number_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"number_key"], @"987",
-                        @"The NSNumber should be converted to a string.");
-
-  XCTAssertTrue([resultDictionary[@"bool_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"bool_key"], @"true",
-                        @"The boolean YES should be converted to the string 'true'.");
-
-  XCTAssertTrue([resultDictionary[@"array_key"] isKindOfClass:[NSString class]],
-                @"The value should be an NSString.");
-  XCTAssertEqualObjects(resultDictionary[@"array_key"], @"[\"a\",false]",
-                        @"The array should be serialized into a JSON string.");
-}
-
-- (void)testStringConversion_withEmptyDictionary_returnsEmptyDictionary {
-  NSDictionary *resultDictionary = [GIDEMMSupport dictionaryWithStringValuesFromDictionary:@{}];
-
-  XCTAssertEqual(resultDictionary.count, 0, @"The resulting dictionary should be empty.");
-}
-
 # pragma mark - Helpers
 
 - (NSString *)systemVersion {