Check bundle optional for localized string (#373)

nrurnru · w-goog · web-flow · commit b37c9d8a96b8 · 2026-04-22T16:54:49.000-07:00
Co-authored-by: Worthing &lt;115107835+w-goog@users.noreply.github.com&gt;
diff --git a/GoogleSignIn/Sources/GIDSignInStrings.m b/GoogleSignIn/Sources/GIDSignInStrings.m
@@ -31,6 +31,9 @@ @implementation GIDSignInStrings
 
 + (nullable NSString *)localizedStringForKey:(NSString *)key text:(NSString *)text {
   NSBundle *frameworkBundle = [NSBundle gid_frameworkBundle];
+  if (frameworkBundle == nil) {
+    return text;
+  }
   return [frameworkBundle localizedStringForKey:key value:text table:kStringsTableName];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,9 @@ @implementation GIDSignInStrings`
`31`	`31`
`32`	`32`	`+ (nullable NSString )localizedStringForKey:(NSString )key text:(NSString *)text {`
`33`	`33`	`NSBundle *frameworkBundle = [NSBundle gid_frameworkBundle];`
	`34`	`+ if (frameworkBundle == nil) {`
	`35`	`+ return text;`
	`36`	`+ }`
`34`	`37`	`return [frameworkBundle localizedStringForKey:key value:text table:kStringsTableName];`
`35`	`38`	`}`
`36`	`39`