free partial operator on alloc failure in create paths#10542
Merged
copybara-service[bot] merged 1 commit intoJun 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spotted while tracing the create error paths against xnn_delete_operator: in xnn_create_resize_bilinear2d_nhwc, xnn_create_unary_elementwise_nc, create_unary_elementwise_nc, xnn_create_binary_elementwise_nd and create_pack_lh the operator struct is allocated first and then a sub-buffer (compute, and resize_op->convolution_op), but a failed sub-buffer allocation returns out-of-memory directly and leaks the partial operator, whereas the sibling creates (softmax-nc, fully-connected-nc, batch-matrix-multiply-nc, reduce-nd, slice-nd, transpose-nd, the pooling ops) all release it via goto error; this releases it with xnn_delete_operator before the same return.