Add overflow detection to shape multiplication functions#9987
Open
TristanInSec wants to merge 1 commit intogoogle:masterfrom
Open
Add overflow detection to shape multiplication functions#9987TristanInSec wants to merge 1 commit intogoogle:masterfrom
TristanInSec wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The five shape multiplication functions multiply size_t dimensions in a loop without checking for overflow. On platforms where size_t is 32-bit (ARM32, WebAssembly), dimension products exceeding 2^32 silently wrap, causing get_tensor_size() to return undersized allocation sizes. Add a checked_mul helper using __builtin_mul_overflow that returns SIZE_MAX on overflow. This propagates through the multiplication chain so callers see SIZE_MAX instead of a wrapped value.
TristanInSec
force-pushed
the
fix-shape-multiply-overflow
branch
from
65d4bc0 to
20114ad
Compare
Author
|
Hi, friendly ping on this PR (and the related #9988). Let me know if any changes are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xnn_shape_multiply_*variants intensor.c__builtin_mul_overflowto detect when dimension products exceedSIZE_MAXSIZE_MAXon overflow instead of a silently wrapped valuesize_tis 32-bit (ARM32, WebAssembly)Test plan