feat: implement workflow validation to reject duplicate edges and remove redundant edge filtering logic#808
Merged
Conversation
wolo-lab
requested changes
May 11, 2026
wolo-lab
approved these changes
May 14, 2026
anFatum
approved these changes
May 15, 2026
…ove redundant edge filtering logic
hanorik
force-pushed
the
edges_validator
branch
2 times, most recently
from
cc789d2 to
e8692ae
Compare
wolo-lab
pushed a commit
that referenced
this pull request
May 18, 2026
…ove redundant edge filtering logic (#808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces validation to ensure that a workflow graph does not contain duplicate edges (multiple edges from the same source to the exact same destination). Enforcing this constraint at workflow creation time allows us to simplify the traversal logic during execution.
Key Changes:
validation.go:validateUniqueEdgesto check for duplicate edges.validateWorkflowas a centralized entry point for workflow validation.ErrDuplicateEdge.workflow.go:Newto run the validation checks and fail if they do not pass.findNextNodeswhich was previously used to filter out duplicate target nodes during traversal.validation_test.go: Added unit tests to verify that duplicate edges are correctly detected.workflow_test.go: Removed a test case inTestWorkflowRoutingthat relied on duplicate edges, as this configuration is now invalid.