feat: implement unconditional cycle detection in workflow validation#811
Merged
Conversation
hanorik
changed the title
wolo-lab
approved these changes
May 14, 2026
wolo-lab
reviewed
May 14, 2026
wolo-lab
requested changes
May 14, 2026
wolo-lab
approved these changes
May 15, 2026
anFatum
approved these changes
May 15, 2026
wolo-lab
pushed a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces validation to detect unconditional cycles in the workflow graph. Cycles that consist entirely of edges without routing conditions (where
edge.Route == nil) are now detected and reported as errors, while conditional cycles are permitted.Key Changes:
validateCyclesinvalidation.gousing a Depth-First Search (DFS) algorithm that tracks the current path (stack) to identify cycles, specifically ignoring edges with non-nil routes.TestValidateCyclesinvalidation_test.goto verify behavior with no cycles, only conditional cycles, and mixed cycles.