Commit 5029081
committed
fix(dev): keep '*' CORS default, drive WebSocket origins from config, warn on '*'
Per review, retain backwards compatibility instead of changing the default
origin allowlist:
- Revert the default origins back to "*" (no change vs HEAD).
- Derive the /run_live WebSocket allowed origins from adk.web.cors.origins
instead of a hardcoded "*", so both HTTP CORS and the WebSocket can be
locked down via the single property.
- Log a startup WARN when origins is "*", noting it is insecure (dev only)
and pointing users to set adk.web.cors.origins.1 parent cb73317 commit 5029081
3 files changed
Lines changed: 15 additions & 6 deletions
File tree
- dev/src/main/java/com/google/adk/web
- config
- websocket
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| 47 | + | |
| 48 | + | |
45 | 49 | | |
46 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
47 | 59 | | |
48 | 60 | | |
49 | | - | |
| 61 | + | |
50 | 62 | | |
51 | 63 | | |
52 | 64 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 37 | + | |
41 | 38 | | |
42 | 39 | | |
43 | 40 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
0 commit comments