feat(HITL): Let ADK resume after HITL approval is present

feat(HITL): Declining a proposal now correctly intercepts the run

fix: Events for HITL are now emitted correctly
fix: HITL endless loop when asking for approvals
PiperOrigin-RevId: 839858592

Author: google-genai-bot

core/src/main/java/com/google/adk/flows/llmflows/Functions.java

@@ -64,7 +64,7 @@
 public final class Functions {
 
   private static final String AF_FUNCTION_CALL_ID_PREFIX = "adk-";
-  static final String REQUEST_CONFIRMATION_FUNCTION_CALL_NAME = "adk_request_confirmation";
+  public static final String REQUEST_CONFIRMATION_FUNCTION_CALL_NAME = "adk_request_confirmation";
   private static final Logger logger = LoggerFactory.getLogger(Functions.class);
 
   /** Generates a unique ID for a function call. */
@@ -147,12 +147,22 @@ public static Maybe<Event> handleFunctionCalls(
     Function<FunctionCall, Maybe<Event>> functionCallMapper =
         functionCall -> {
           BaseTool tool = tools.get(functionCall.name().get());
+          ToolConfirmation toolConfirmation = toolConfirmations.get(functionCall.id().orElse(null));
           ToolContext toolContext =
               ToolContext.builder(invocationContext)
                   .functionCallId(functionCall.id().orElse(""))
-                  .toolConfirmation(toolConfirmations.get(functionCall.id().orElse(null)))
+                  .toolConfirmation(toolConfirmation)
                   .build();
 
+          if (toolConfirmation != null && !toolConfirmation.confirmed()) {
+            return Maybe.just(
+                buildResponseEvent(
+                    tool,
+                    ImmutableMap.of("error", "User declined tool execution for " + tool.name()),
+                    toolContext,
+                    invocationContext));
+          }
+
           Map<String, Object> functionArgs = functionCall.args().orElse(ImmutableMap.of());
 
           Maybe<Map<String, Object>> maybeFunctionResult =
@@ -241,6 +251,18 @@ public static Maybe<Event> handleFunctionCalls(
    */
   public static Maybe<Event> handleFunctionCallsLive(
       InvocationContext invocationContext, Event functionCallEvent, Map<String, BaseTool> tools) {
+    return handleFunctionCallsLive(invocationContext, functionCallEvent, tools, ImmutableMap.of());
+  }
+
+  /**
+   * Handles function calls in a live/streaming context with tool confirmations, supporting
+   * background execution and stream termination.
+   */
+  public static Maybe<Event> handleFunctionCallsLive(
+      InvocationContext invocationContext,
+      Event functionCallEvent,
+      Map<String, BaseTool> tools,
+      Map<String, ToolConfirmation> toolConfirmations) {
     ImmutableList<FunctionCall> functionCalls = functionCallEvent.functionCalls();
 
     for (FunctionCall functionCall : functionCalls) {
@@ -255,7 +277,9 @@ public static Maybe<Event> handleFunctionCallsLive(
           ToolContext toolContext =
               ToolContext.builder(invocationContext)
                   .functionCallId(functionCall.id().orElse(""))
+                  .toolConfirmation(toolConfirmations.get(functionCall.id().orElse(null)))
                   .build();
+
           Map<String, Object> functionArgs = functionCall.args().orElse(new HashMap<>());
 
           Maybe<Map<String, Object>> maybeFunctionResult =

core/src/main/java/com/google/adk/flows/llmflows/RequestConfirmationLlmRequestProcessor.java

@@ -19,10 +19,11 @@
 import static com.google.adk.flows.llmflows.Functions.REQUEST_CONFIRMATION_FUNCTION_CALL_NAME;
 import static com.google.common.collect.ImmutableList.toImmutableList;
 import static com.google.common.collect.ImmutableMap.toImmutableMap;
+import static com.google.common.collect.ImmutableSet.toImmutableSet;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
+import com.google.adk.JsonBaseModel;
 import com.google.adk.agents.InvocationContext;
 import com.google.adk.agents.LlmAgent;
 import com.google.adk.events.Event;
@@ -31,14 +32,15 @@
 import com.google.adk.tools.ToolConfirmation;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
 import com.google.genai.types.Content;
 import com.google.genai.types.FunctionCall;
 import com.google.genai.types.FunctionResponse;
 import com.google.genai.types.Part;
 import io.reactivex.rxjava3.core.Maybe;
 import io.reactivex.rxjava3.core.Single;
 import java.util.Collection;
-import java.util.List;
+import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
@@ -49,59 +51,123 @@
 public class RequestConfirmationLlmRequestProcessor implements RequestProcessor {
   private static final Logger logger =
       LoggerFactory.getLogger(RequestConfirmationLlmRequestProcessor.class);
-  private final ObjectMapper objectMapper;
-
-  public RequestConfirmationLlmRequestProcessor() {
-    objectMapper = new ObjectMapper().registerModule(new Jdk8Module());
-  }
+  private static final ObjectMapper OBJECT_MAPPER = JsonBaseModel.getMapper();
 
   @Override
   public Single<RequestProcessor.RequestProcessingResult> processRequest(
       InvocationContext invocationContext, LlmRequest llmRequest) {
-    List<Event> events = invocationContext.session().events();
+    ImmutableList<Event> events = ImmutableList.copyOf(invocationContext.session().events());
     if (events.isEmpty()) {
       logger.info(
           "No events are present in the session. Skipping request confirmation processing.");
       return Single.just(RequestProcessingResult.create(llmRequest, ImmutableList.of()));
     }
 
-    ImmutableMap<String, ToolConfirmation> requestConfirmationFunctionResponses =
-        filterRequestConfirmationFunctionResponses(events);
+    ImmutableMap<String, ToolConfirmation> responses = ImmutableMap.of();
+    int confirmationEventIndex = -1;
+    for (int i = events.size() - 1; i >= 0; i--) {
+      Event event = events.get(i);
+      if (!Objects.equals(event.author(), "user")) {
+        continue;
+      }
+      if (event.functionResponses().isEmpty()) {
+        continue;
+      }
+      responses =
+          event.functionResponses().stream()
+              .filter(functionResponse -> functionResponse.id().isPresent())
+              .filter(
+                  functionResponse ->
+                      Objects.equals(
+                          functionResponse.name().orElse(null),
+                          REQUEST_CONFIRMATION_FUNCTION_CALL_NAME))
+              .map(this::maybeCreateToolConfirmationEntry)
+              .flatMap(Optional::stream)
+              .collect(toImmutableMap(Map.Entry::getKey, Map.Entry::getValue));
+      confirmationEventIndex = i;
+      break;
+    }
+
+    // Make it final to enable access from lambda expressions.
+    final ImmutableMap<String, ToolConfirmation> requestConfirmationFunctionResponses = responses;
+
     if (requestConfirmationFunctionResponses.isEmpty()) {
       logger.info("No request confirmation function responses found.");
       return Single.just(RequestProcessingResult.create(llmRequest, ImmutableList.of()));
     }
 
-    for (ImmutableList<FunctionCall> functionCalls :
-        events.stream()
-            .map(Event::functionCalls)
-            .filter(fc -> !fc.isEmpty())
-            .collect(toImmutableList())) {
+    for (int i = events.size() - 2; i >= 0; i--) {
+      Event event = events.get(i);
+      if (event.functionCalls().isEmpty()) {
+        continue;
+      }
+
+      Map<String, ToolConfirmation> toolsToResumeWithConfirmation = new HashMap<>();
+      Map<String, FunctionCall> toolsToResumeWithArgs = new HashMap<>();
+
+      event.functionCalls().stream()
+          .filter(
+              fc ->
+                  fc.id().isPresent()
+                      && requestConfirmationFunctionResponses.containsKey(fc.id().get()))
+          .forEach(
+              fc ->
+                  getOriginalFunctionCall(fc)
+                      .ifPresent(
+                          ofc -> {
+                            toolsToResumeWithConfirmation.put(
+                                ofc.id().get(),
+                                requestConfirmationFunctionResponses.get(fc.id().get()));
+                            toolsToResumeWithArgs.put(ofc.id().get(), ofc);
+                          }));
+
+      if (toolsToResumeWithConfirmation.isEmpty()) {
+        continue;
+      }
+
+      // Remove the tools that have already been confirmed.
+      ImmutableSet<String> alreadyConfirmedIds =
+          events.subList(confirmationEventIndex + 1, events.size()).stream()
+              .flatMap(e -> e.functionResponses().stream())
+              .map(FunctionResponse::id)
+              .flatMap(Optional::stream)
+              .collect(toImmutableSet());
+      toolsToResumeWithConfirmation.keySet().removeAll(alreadyConfirmedIds);
+      toolsToResumeWithArgs.keySet().removeAll(alreadyConfirmedIds);
 
-      ImmutableMap<String, FunctionCall> toolsToResumeWithArgs =
-          filterToolsToResumeWithArgs(functionCalls, requestConfirmationFunctionResponses);
-      ImmutableMap<String, ToolConfirmation> toolsToResumeWithConfirmation =
-          toolsToResumeWithArgs.keySet().stream()
-              .filter(
-                  id ->
-                      events.stream()
-                          .flatMap(e -> e.functionResponses().stream())
-                          .anyMatch(fr -> Objects.equals(fr.id().orElse(null), id)))
-              .collect(toImmutableMap(k -> k, requestConfirmationFunctionResponses::get));
       if (toolsToResumeWithConfirmation.isEmpty()) {
-        logger.info("No tools to resume with confirmation.");
         continue;
       }
 
       return assembleEvent(
-              invocationContext, toolsToResumeWithArgs.values(), toolsToResumeWithConfirmation)
-          .map(event -> RequestProcessingResult.create(llmRequest, ImmutableList.of(event)))
+              invocationContext,
+              toolsToResumeWithArgs.values(),
+              ImmutableMap.copyOf(toolsToResumeWithConfirmation))
+          .map(e -> RequestProcessingResult.create(llmRequest, ImmutableList.of(e)))
           .toSingle();
     }
 
     return Single.just(RequestProcessingResult.create(llmRequest, ImmutableList.of()));
   }
 
+  private Optional<FunctionCall> getOriginalFunctionCall(FunctionCall functionCall) {
+    if (!functionCall.args().orElse(ImmutableMap.of()).containsKey("originalFunctionCall")) {
+      return Optional.empty();
+    }
+    try {
+      FunctionCall originalFunctionCall =
+          OBJECT_MAPPER.convertValue(
+              functionCall.args().get().get("originalFunctionCall"), FunctionCall.class);
+      if (originalFunctionCall.id().isEmpty()) {
+        return Optional.empty();
+      }
+      return Optional.of(originalFunctionCall);
+    } catch (IllegalArgumentException e) {
+      logger.warn("Failed to convert originalFunctionCall argument.", e);
+      return Optional.empty();
+    }
+  }
+
   private Maybe<Event> assembleEvent(
       InvocationContext invocationContext,
       Collection<FunctionCall> functionCalls,
@@ -128,58 +194,26 @@ private Maybe<Event> assembleEvent(
         invocationContext, functionCallEvent, toolsBuilder.buildOrThrow(), toolConfirmations);
   }
 
-  private ImmutableMap<String, ToolConfirmation> filterRequestConfirmationFunctionResponses(
-      List<Event> events) {
-    return events.stream()
-        .filter(event -> Objects.equals(event.author(), "user"))
-        .flatMap(event -> event.functionResponses().stream())
-        .filter(functionResponse -> functionResponse.id().isPresent())
-        .filter(
-            functionResponse ->
-                Objects.equals(
-                    functionResponse.name().orElse(null), REQUEST_CONFIRMATION_FUNCTION_CALL_NAME))
-        .map(this::maybeCreateToolConfirmationEntry)
-        .flatMap(Optional::stream)
-        .collect(toImmutableMap(Map.Entry::getKey, Map.Entry::getValue));
-  }
-
   private Optional<Map.Entry<String, ToolConfirmation>> maybeCreateToolConfirmationEntry(
       FunctionResponse functionResponse) {
     Map<String, Object> responseMap = functionResponse.response().orElse(ImmutableMap.of());
     if (responseMap.size() != 1 || !responseMap.containsKey("response")) {
       return Optional.of(
           Map.entry(
               functionResponse.id().get(),
-              objectMapper.convertValue(responseMap, ToolConfirmation.class)));
+              OBJECT_MAPPER.convertValue(responseMap, ToolConfirmation.class)));
     }
 
     try {
       return Optional.of(
           Map.entry(
               functionResponse.id().get(),
-              objectMapper.readValue(
+              OBJECT_MAPPER.readValue(
                   (String) responseMap.get("response"), ToolConfirmation.class)));
     } catch (JsonProcessingException e) {
       logger.error("Failed to parse tool confirmation response", e);
     }
 
     return Optional.empty();
   }
-
-  private ImmutableMap<String, FunctionCall> filterToolsToResumeWithArgs(
-      ImmutableList<FunctionCall> functionCalls,
-      Map<String, ToolConfirmation> requestConfirmationFunctionResponses) {
-    return functionCalls.stream()
-        .filter(fc -> fc.id().isPresent())
-        .filter(fc -> requestConfirmationFunctionResponses.containsKey(fc.id().get()))
-        .filter(
-            fc -> Objects.equals(fc.name().orElse(null), REQUEST_CONFIRMATION_FUNCTION_CALL_NAME))
-        .filter(fc -> fc.args().orElse(ImmutableMap.of()).containsKey("originalFunctionCall"))
-        .collect(
-            toImmutableMap(
-                fc -> fc.id().get(),
-                fc ->
-                    objectMapper.convertValue(
-                        fc.args().get().get("originalFunctionCall"), FunctionCall.class)));
-  }
 }

core/src/main/java/com/google/adk/flows/llmflows/SingleFlow.java

@@ -31,6 +31,7 @@ public class SingleFlow extends BaseLlmFlow {
           new Identity(),
           new Contents(),
           new Examples(),
+          new RequestConfirmationLlmRequestProcessor(),
           CodeExecution.requestProcessor);
 
   protected static final ImmutableList<ResponseProcessor> RESPONSE_PROCESSORS =

core/src/main/java/com/google/adk/tools/ToolContext.java

@@ -127,6 +127,20 @@ public Builder toBuilder() {
         .toolConfirmation(toolConfirmation.orElse(null));
   }
 
+  @Override
+  public String toString() {
+    return "ToolContext{"
+        + "invocationContext="
+        + invocationContext
+        + ", eventActions="
+        + eventActions
+        + ", functionCallId="
+        + functionCallId
+        + ", toolConfirmation="
+        + toolConfirmation
+        + '}';
+  }
+
   /** Builder for {@link ToolContext}. */
   public static final class Builder {
     private final InvocationContext invocationContext;