Ensure all properties are copied when converting to a2a

[zbirkenbuel]

Python and Go implementations of ADK both copy function call and response properties by copying the entire struct automatically. Java does this a property at a time and so was missing the "id" property of the ADK event. Providing these allows downstream agents to properly associate multiple tool calls and responses to the same tool name.

Updated EventConverterTest to verify the new field and also verified function name in the response object.

[gemini-code-assist]

Summary of Changes

Hello @zbirkenbuel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency in the Java ADK implementation where the 'id' property for function call and response events was not being propagated during conversion to the a2a format. By explicitly copying this 'id' field, the Java ADK now behaves consistently with its Python and Go counterparts, which automatically handle such property transfers. This change is crucial for ensuring that downstream systems can accurately link related tool calls and their corresponding responses.

Highlights

• Java ADK Consistency: Aligns Java's ADK event conversion with Python and Go by ensuring the 'id' property is copied for function calls and responses.
• Function Call/Response Association: Enables downstream agents to correctly associate multiple tool calls and responses by preserving the 'id' field.
• PartConverter Update: Modifies PartConverter.java to extract and include the 'id' field when converting between DataPart and GenAiPart for function calls and responses.
• Test Coverage: Updates EventConverterTest.java to include assertions for the newly copied 'id' field and to verify the function name in the response object.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for a functionId field within FunctionCall and FunctionResponse objects. The PartConverter.java file was updated to extract the functionId from incoming data parts and include it when constructing FunctionCall and FunctionResponse objects, as well as to serialize the functionId back into DataPart structures. Corresponding test cases in EventConverterTest.java were modified to include and assert the presence and correctness of the functionId in both function call and response parts during conversion.