Skip to content

Commit 0463677

Browse files
committed
refactor(test): simplify metadata assertions with object equality
Applied Gemini Code Assist suggestion to make test more concise and maintainable by using direct object comparison instead of field-by-field assertions. Pydantic models support equality comparison natively.
1 parent ca5f1e9 commit 0463677

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

tests/unittests/sessions/test_vertex_ai_session_service.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,17 +1088,6 @@ async def test_append_event_with_cache_and_usage_metadata():
10881088

10891089
appended_event = retrieved_session.events[-1]
10901090
# cache_metadata is preserved
1091-
assert appended_event.cache_metadata is not None
1092-
assert appended_event.cache_metadata.cache_name == (
1093-
'projects/123/locations/us-central1/cachedContents/456'
1094-
)
1095-
assert appended_event.cache_metadata.fingerprint == 'abc123hash'
1096-
assert appended_event.cache_metadata.invocations_used == 3
1097-
assert appended_event.cache_metadata.contents_count == 10
1098-
assert appended_event.cache_metadata.created_at == 1700000000.0
1091+
assert appended_event.cache_metadata == cache_meta
10991092
# usage_metadata is preserved
1100-
assert appended_event.usage_metadata is not None
1101-
assert appended_event.usage_metadata.prompt_token_count == 100
1102-
assert appended_event.usage_metadata.candidates_token_count == 50
1103-
assert appended_event.usage_metadata.total_token_count == 150
1104-
assert appended_event.usage_metadata.cached_content_token_count == 80
1093+
assert appended_event.usage_metadata == usage_meta

0 commit comments

Comments
 (0)