Commit 2024ead
committed
fix: Resolve HIGH priority grounding_metadata state management issues
- Add interrupted parameter to __build_full_text_response to preserve interrupted signal when flushing pending text
- Pass interrupted flag in turn_complete and interrupted blocks
- Remove premature reset of last_grounding_metadata after interrupted (not a terminal event)
- Add documentation for tool_call metadata persistence design decision
Addresses review comments:
- HIGH: Lost interrupted signal in full text response
- HIGH: Premature reset after interrupted
- MEDIUM: Duplicate reset logic (simplified by removing premature reset)1 parent a8e16ab commit 2024ead
1 file changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| 146 | + | |
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| |||
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
| 156 | + | |
155 | 157 | | |
156 | 158 | | |
157 | 159 | | |
| |||
162 | 164 | | |
163 | 165 | | |
164 | 166 | | |
| 167 | + | |
165 | 168 | | |
166 | 169 | | |
167 | 170 | | |
| |||
295 | 298 | | |
296 | 299 | | |
297 | 300 | | |
298 | | - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
299 | 304 | | |
300 | 305 | | |
301 | 306 | | |
| |||
312 | 317 | | |
313 | 318 | | |
314 | 319 | | |
315 | | - | |
| 320 | + | |
316 | 321 | | |
317 | 322 | | |
318 | 323 | | |
319 | 324 | | |
320 | 325 | | |
321 | 326 | | |
322 | 327 | | |
323 | | - | |
324 | 328 | | |
325 | 329 | | |
326 | 330 | | |
| |||
333 | 337 | | |
334 | 338 | | |
335 | 339 | | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
336 | 344 | | |
337 | 345 | | |
338 | 346 | | |
| |||
0 commit comments